From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
To: michael@niedermayer.cc
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>, ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/nutdec: Add check for avformat_new_stream
Date: Wed, 23 Feb 2022 10:14:45 +0800
Message-ID: <20220223021445.2789157-1-jiasheng@iscas.ac.cn> (raw)
Michael Niedermayer:
>> diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
>> index 0a8a700acf..32a4f6bbcb 100644
>> --- a/libavformat/nutdec.c
>> +++ b/libavformat/nutdec.c
>> @@ -351,8 +351,13 @@ static int decode_main_header(NUTContext *nut)
>> ret = AVERROR(ENOMEM);
>> goto fail;
>> }
>> - for (i = 0; i < stream_count; i++)
>> - avformat_new_stream(s, NULL);
>> + for (i = 0; i < stream_count; i++) {
>> + if (!avformat_new_stream(s, NULL)) {
>> + av_freep(nut->stream);
>
> is this actually needed or isnt this freed anyway ?
> also if needed thats the wrong pointer
> av_freep(&nut->stream)
OK, I will remove it and submit v4.
Jiang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-02-23 2:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 2:14 Jiasheng Jiang [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-22 2:41 Jiasheng Jiang
2022-02-22 16:30 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223021445.2789157-1-jiasheng@iscas.ac.cn \
--to=jiasheng@iscas.ac.cn \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=michael@niedermayer.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git