From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
To: ffmpeg-devel@ffmpeg.org
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: [FFmpeg-devel] [PATCH] avcodec/magicyuvenc: Add check for av_frame_clone
Date: Tue, 22 Feb 2022 15:23:23 +0800
Message-ID: <20220222072323.2685366-1-jiasheng@iscas.ac.cn> (raw)
As the potential failure of the memory allocation,
the 'p' could be NULL pointer.
Therefore, it should be better to check it in order
to avoid the dereferencing of the NULL pointer.
Fixes: 3729ae659f ("avcodec: add MagicYUV encoder")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
libavcodec/magicyuvenc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c
index ab32d4cee3..b763916b87 100644
--- a/libavcodec/magicyuvenc.c
+++ b/libavcodec/magicyuvenc.c
@@ -454,6 +454,8 @@ static int magy_encode_frame(AVCodecContext *avctx, AVPacket *pkt,
if (s->correlate) {
uint8_t *r, *g, *b;
AVFrame *p = av_frame_clone(frame);
+ if (!p)
+ return AVERROR(ENOMEM);
g = p->data[0];
b = p->data[1];
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2022-02-22 7:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222072323.2685366-1-jiasheng@iscas.ac.cn \
--to=jiasheng@iscas.ac.cn \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git