Re: [FFmpeg-devel] [PATCH v2 1/5] avutil: [loongarch] Update loongson_intrinsics.h to v1.1.0

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil: [loongarch] Update loongson_intrinsics.h to v1.1.0
Date: Mon, 21 Feb 2022 16:00:35 +0100
Message-ID: <20220221150035.GZ2829255@pb2> (raw)
In-Reply-To: <20220217111151.28498-2-chenhao@loongson.cn>

[-- Attachment #1.1: Type: text/plain, Size: 2510 bytes --]

On Thu, Feb 17, 2022 at 07:11:47PM +0800, Hao Chen wrote:
> The loongson_intrinsics.h file is updated from v1.0.3 version
> to v1.1.0. Some spelling mistakes are fixed and new functions are added.
> 
> Signed-off-by: Hao Chen <chenhao@loongson.cn>
> ---
>  libavutil/loongarch/loongson_intrinsics.h | 1697 +++++++++++----------
>  1 file changed, 884 insertions(+), 813 deletions(-)
> 
> diff --git a/libavutil/loongarch/loongson_intrinsics.h b/libavutil/loongarch/loongson_intrinsics.h
> index 6e0439f829..eb256863c8 100644
> --- a/libavutil/loongarch/loongson_intrinsics.h
> +++ b/libavutil/loongarch/loongson_intrinsics.h
> @@ -33,7 +33,7 @@
>   *                Xiwei Gu   <guxiwei-hf@loongson.cn>
>   *                Lu Wang    <wanglu@loongson.cn>
>   *
> - * This file is a header file for loongarch builtin extention.
> + * This file is a header file for loongarch builtin extension.
>   *
>   */
>  
> @@ -42,50 +42,50 @@
>  
>  /**
>   * MAJOR version: Macro usage changes.
> - * MINOR version: Add new functions, or bug fix.
> + * MINOR version: Add new functions, or bug fixes.
>   * MICRO version: Comment changes or implementation changes.
>   */
>  #define LSOM_VERSION_MAJOR 1
> -#define LSOM_VERSION_MINOR 0
> -#define LSOM_VERSION_MICRO 3
> +#define LSOM_VERSION_MINOR 1
> +#define LSOM_VERSION_MICRO 0
>  
>  #define DUP2_ARG1(_INS, _IN0, _IN1, _OUT0, _OUT1) \
> -{ \
> -    _OUT0 = _INS(_IN0); \
> -    _OUT1 = _INS(_IN1); \
> -}
> +  {                                               \
> +    _OUT0 = _INS(_IN0);                           \
> +    _OUT1 = _INS(_IN1);                           \
> +  }
>  
>  #define DUP2_ARG2(_INS, _IN0, _IN1, _IN2, _IN3, _OUT0, _OUT1) \
> -{ \
> -    _OUT0 = _INS(_IN0, _IN1); \
> -    _OUT1 = _INS(_IN2, _IN3); \
> -}
> +  {                                                           \
> +    _OUT0 = _INS(_IN0, _IN1);                                 \
> +    _OUT1 = _INS(_IN2, _IN3);                                 \
> +  }

These style changes differ from the recommandition in doc/developer.texi
is that intentional ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".