From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D51C84008D for ; Thu, 17 Feb 2022 12:10:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1F00668B30C; Thu, 17 Feb 2022 14:10:33 +0200 (EET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA8C068AEFA for ; Thu, 17 Feb 2022 14:10:26 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id D769E100009 for ; Thu, 17 Feb 2022 12:10:25 +0000 (UTC) Date: Thu, 17 Feb 2022 13:10:24 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220217121024.GN2829255@pb2> References: <20220217091315.21092-1-anton@khirnov.net> <20220217091315.21092-2-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20220217091315.21092-2-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/dxva: properly namespace public symbols X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7800359867800967842==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7800359867800967842== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vG8cDnDm7DFt1yHb" Content-Disposition: inline --vG8cDnDm7DFt1yHb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 17, 2022 at 10:13:15AM +0100, Anton Khirnov wrote: > --- > doc/APIchanges | 6 ++++++ > libavcodec/dxva2.c | 4 ++-- > libavcodec/dxva2.h | 18 ++++++++++++++---- > libavcodec/dxva2_h264.c | 8 ++++---- > libavcodec/dxva2_internal.h | 4 ++-- > libavcodec/version.h | 3 ++- > 6 files changed, 30 insertions(+), 13 deletions(-) This doesnt build CC libavcodec/dxva2.o In file included from src/libavcodec/dxva2_internal.h:34:0, from src/libavcodec/dxva2.c:33: src/libavcodec/dxva2.h:23:0: error: unterminated #ifndef #ifndef AVCODEC_DXVA2_H =20 In file included from src/libavcodec/dxva2_internal.h:35:0, from src/libavcodec/dxva2.c:33: src/libavutil/hwcontext_dxva2.h:39:1: error: duplicate =E2=80=98typedef=E2= =80=99 typedef struct AVDXVA2DeviceContext { ^~~~~~~ src/libavutil/hwcontext_dxva2.h:39:9: error: two or more data types in decl= aration specifiers typedef struct AVDXVA2DeviceContext { ^~~~~~ In file included from src/libavcodec/dxva2_internal.h:38:0, from src/libavcodec/dxva2.c:33: src/libavcodec/d3d11va.h:48:0: warning: "FF_DXVA2_WORKAROUND_SCALING_LIST_Z= IGZAG" redefined #define FF_DXVA2_WORKAROUND_SCALING_LIST_ZIGZAG 1 ///< Work around for Dir= ect3D11 and old UVD/UVD+ ATI video cards =20 In file included from src/libavcodec/dxva2_internal.h:34:0, from src/libavcodec/dxva2.c:33: src/libavcodec/dxva2.h:52:0: note: this is the location of the previous def= inition #define FF_DXVA2_WORKAROUND_SCALING_LIST_ZIGZAG AV_DXVA2_WORKAROUND_SCALIN= G_LIST_ZIGZAG =20 In file included from src/libavcodec/dxva2_internal.h:38:0, from src/libavcodec/dxva2.c:33: src/libavcodec/d3d11va.h:49:0: warning: "FF_DXVA2_WORKAROUND_INTEL_CLEARVID= EO" redefined #define FF_DXVA2_WORKAROUND_INTEL_CLEARVIDEO 2 ///< Work around for Dir= ect3D11 and old Intel GPUs with ClearVideo interface =20 In file included from src/libavcodec/dxva2_internal.h:34:0, from src/libavcodec/dxva2.c:33: src/libavcodec/dxva2.h:53:0: note: this is the location of the previous def= inition #define FF_DXVA2_WORKAROUND_INTEL_CLEARVIDEO AV_DXVA2_WORKAROUND_INTEL_= CLEARVIDEO =20 In file included from src/libavcodec/dxva2.c:33:0: src/libavcodec/dxva2_internal.h:63:5: error: unknown type name =E2=80=98AVD= XVA2DecodeContext=E2=80=99 AVDXVA2DecodeContext dxva2; ^~~~~~~~~~~~~~~~~~~~ In file included from src/libavcodec/dxva2.h:39:0, from src/libavcodec/dxva2_internal.h:34, from src/libavcodec/dxva2.c:33: src/libavcodec/dxva2.c: In function =E2=80=98dxva2_create_decoder=E2=80=99: src/libavcodec/dxva2.c:359:63: error: dereferencing pointer to incomplete t= ype =E2=80=98AVDXVA2DeviceContext {aka struct dxva_context}=E2=80=99 hr =3D IDirect3DDeviceManager9_OpenDeviceHandle(device_hwctx->devmgr, ^ src/libavcodec/dxva2.c: In function =E2=80=98ff_dxva2_decode_init=E2=80=99: src/libavcodec/dxva2.c:707:9: error: unknown type name =E2=80=98AVDXVA2Deco= deContext=E2=80=99; did you mean =E2=80=98AVDXVA2DeviceContext=E2=80=99? AVDXVA2DecodeContext *dxva_ctx =3D &sctx->ctx.dxva2; ^~~~~~~~~~~~~~~~~~~~ AVDXVA2DeviceContext src/libavcodec/dxva2.c:715:17: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union dxva_ctx->decoder =3D sctx->dxva2_decoder; ^~ src/libavcodec/dxva2.c:716:17: error: request for member =E2=80=98cfg=E2=80= =99 in something not a structure or union dxva_ctx->cfg =3D &sctx->dxva2_config; ^~ src/libavcodec/dxva2.c:717:17: error: request for member =E2=80=98surface= =E2=80=99 in something not a structure or union dxva_ctx->surface =3D frames_hwctx->surfaces; ^~ src/libavcodec/dxva2.c:718:17: error: request for member =E2=80=98surface_c= ount=E2=80=99 in something not a structure or union dxva_ctx->surface_count =3D frames_hwctx->nb_surfaces; ^~ src/libavcodec/dxva2.c:719:17: error: request for member =E2=80=98workaroun= d=E2=80=99 in something not a structure or union dxva_ctx->workaround =3D sctx->workaround; ^~ In file included from src/libavcodec/dxva2.c:33:0: src/libavcodec/dxva2.c: In function =E2=80=98ff_dxva2_get_surface_index=E2= =80=99: src/libavcodec/dxva2_internal.h:106:116: error: request for member =E2=80= =98surface_count=E2=80=99 in something not a structure or union #define DXVA_CONTEXT_COUNT(avctx, ctx) (ff_dxva2_is_d3d11(avctx) = ? ctx->d3d11va.surface_count : ctx->dxva2.surface_count) = ^ src/libavcodec/dxva2.c:787:21: note: in expansion of macro =E2=80=98DXVA_CO= NTEXT_COUNT=E2=80=99 for (i =3D 0; i < DXVA_CONTEXT_COUNT(avctx, ctx); i++) { ^ src/libavcodec/dxva2.c:788:65: error: request for member =E2=80=98surface= =E2=80=99 in something not a structure or union if (avctx->pix_fmt =3D=3D AV_PIX_FMT_DXVA2_VLD && ctx->dxva2.surfa= ce[i] =3D=3D surface) ^ In file included from src/libavcodec/dxva2.h:39:0, from src/libavcodec/dxva2_internal.h:34, from src/libavcodec/dxva2.c:33: src/libavcodec/dxva2.c: In function =E2=80=98ff_dxva2_commit_buffer=E2=80= =99: src/libavcodec/dxva2.c:817:63: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_GetBuffer(DXVA2_CONTEXT(ctx)->decoder,= type, ^ src/libavcodec/dxva2.c:817:63: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_GetBuffer(DXVA2_CONTEXT(ctx)->decoder,= type, ^ src/libavcodec/dxva2.c:859:67: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_ReleaseBuffer(DXVA2_CONTEXT(ctx)->deco= der, type); ^ src/libavcodec/dxva2.c:859:67: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_ReleaseBuffer(DXVA2_CONTEXT(ctx)->deco= der, type); ^ src/libavcodec/dxva2.c: In function =E2=80=98ff_dxva2_common_end_frame=E2= =80=99: src/libavcodec/dxva2.c:923:68: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_BeginFrame(DXVA2_CONTEXT(ctx)->dec= oder, ^ src/libavcodec/dxva2.c:923:68: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_BeginFrame(DXVA2_CONTEXT(ctx)->dec= oder, ^ src/libavcodec/dxva2.c:1025:61: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_Execute(DXVA2_CONTEXT(ctx)->decoder, &= exec); ^ src/libavcodec/dxva2.c:1025:61: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_Execute(DXVA2_CONTEXT(ctx)->decoder, &= exec); ^ src/libavcodec/dxva2.c:1040:62: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_EndFrame(DXVA2_CONTEXT(ctx)->decoder, = NULL); ^ src/libavcodec/dxva2.c:1040:62: error: request for member =E2=80=98decoder= =E2=80=99 in something not a structure or union hr =3D IDirectXVideoDecoder_EndFrame(DXVA2_CONTEXT(ctx)->decoder, = NULL); ^ src/ffbuild/common.mak:78: recipe for target 'libavcodec/dxva2.o' failed make: *** [libavcodec/dxva2.o] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to suggest that students drop out of college or go to community college in order to be able to afford settlements. -- The RIAA --vG8cDnDm7DFt1yHb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYg47LAAKCRBhHseHBAsP q2ilAKCYKFrI6HEt5iMU4PRopcGOkJEUJgCgmeKU1g7Xyg9pcNthPloFYWDbeFg= =JzE8 -----END PGP SIGNATURE----- --vG8cDnDm7DFt1yHb-- --===============7800359867800967842== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7800359867800967842==--