From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A665241A1D for ; Wed, 16 Feb 2022 19:02:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 04ED968B262; Wed, 16 Feb 2022 21:02:21 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2842A68AFDD for ; Wed, 16 Feb 2022 21:02:12 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 154FB60006 for ; Wed, 16 Feb 2022 19:02:10 +0000 (UTC) Date: Wed, 16 Feb 2022 20:02:08 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220216190208.GL2829255@pb2> References: <20220215215228.12252-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/3] avfilter: Rename blend_modes.c -> blend_modes_template.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4981087496822743136==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4981087496822743136== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QqoAFJW0Wwrf1M3c" Content-Disposition: inline --QqoAFJW0Wwrf1M3c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 16, 2022 at 05:38:04AM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > This is more consistent with similar usage > >=20 > > Signed-off-by: Michael Niedermayer > > --- > > .../{blend_modes.c =3D> blend_modes_template.c} | 0 > > libavfilter/vf_blend.c | 14 +++++++------- > > 2 files changed, 7 insertions(+), 7 deletions(-) > > rename libavfilter/{blend_modes.c =3D> blend_modes_template.c} (100%) > >=20 > > diff --git a/libavfilter/blend_modes.c b/libavfilter/blend_modes_templa= te.c > > similarity index 100% > > rename from libavfilter/blend_modes.c > > rename to libavfilter/blend_modes_template.c > > diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c > > index 2d433e439f..e912ba4cb8 100644 > > --- a/libavfilter/vf_blend.c > > +++ b/libavfilter/vf_blend.c > > @@ -34,31 +34,31 @@ > > #define BOTTOM 1 > > =20 > > #define DEPTH 8 > > -#include "blend_modes.c" > > +#include "blend_modes_template.c" > > =20 > > #undef DEPTH > > #define DEPTH 9 > > -#include "blend_modes.c" > > +#include "blend_modes_template.c" > > =20 > > #undef DEPTH > > #define DEPTH 10 > > -#include "blend_modes.c" > > +#include "blend_modes_template.c" > > =20 > > #undef DEPTH > > #define DEPTH 12 > > -#include "blend_modes.c" > > +#include "blend_modes_template.c" > > =20 > > #undef DEPTH > > #define DEPTH 14 > > -#include "blend_modes.c" > > +#include "blend_modes_template.c" > > =20 > > #undef DEPTH > > #define DEPTH 16 > > -#include "blend_modes.c" > > +#include "blend_modes_template.c" > > =20 > > #undef DEPTH > > #define DEPTH 32 > > -#include "blend_modes.c" > > +#include "blend_modes_template.c" > > =20 > > typedef struct BlendContext { > > const AVClass *class; >=20 > Right now make's vf_blend.d contains an entry > src/libavfilter/blend_modes.c; if one applies this patch, said file does > no longer exist and make errors out with "No rule to make target > 'src/libavfilter/blend_modes.c', needed by 'libavfilter/vf_blend.o'.", > because the blend_modes.c prerequisite can't be made. In > 3044d0efee9136c19dfdcf6dcdf957e910a73fd5 I made the build process treat > templates just like headers so that they can be deleted without this > error. Would there be any negative side-effects of doing the same for > all files? > (Btw: The AC-3 decoder also uses a misnamed template; I didn't fix it > because of the aforementioned issue.) Iam no makefile guru but if you give a rule to fake-make any .c file then .o files build from =2Easm could pick the .c route i dont know when that happens but it does happen sometimes: Considering target file 'libavcodec/x86/fpel.o'. Looking for an implicit rule for 'libavcodec/x86/fpel.o'. Trying pattern rule with stem 'fpel'. Trying implicit prerequisite 'libavcodec/x86/fpel.c'. Found prerequisite 'libavcodec/x86/fpel.c' as VPATH 'src/libavcodec/= x86/fpel.c' Found an implicit rule for 'libavcodec/x86/fpel.o'. Considering target file 'src/libavcodec/x86/fpel.c'. File 'src/libavcodec/x86/fpel.c' does not exist. Looking for an implicit rule for 'src/libavcodec/x86/fpel.c'. Trying pattern rule with stem 'fpel'. Found an implicit rule for 'src/libavcodec/x86/fpel.c'. Finished prerequisites of target file 'src/libavcodec/x86/fpel.c'. Must remake target 'src/libavcodec/x86/fpel.c'. Successfully remade target file 'src/libavcodec/x86/fpel.c'. Pruning file 'libavcodec/'. Pruning file 'libavcodec/x86/'. Considering target file 'src/libavcodec/x86/fpel.asm'. Looking for an implicit rule for 'src/libavcodec/x86/fpel.asm'. Trying pattern rule with stem 'fpel.asm'. Trying implicit prerequisite 'src/libavcodec/x86/fpel.asm,v'. Trying pattern rule with stem 'fpel.asm'. Trying implicit prerequisite 'src/libavcodec/x86/RCS/fpel.asm,v'. Trying pattern rule with stem 'fpel.asm'. Trying implicit prerequisite 'src/libavcodec/x86/RCS/fpel.asm'. Trying pattern rule with stem 'fpel.asm'. Trying implicit prerequisite 'src/libavcodec/x86/s.fpel.asm'. Trying pattern rule with stem 'fpel.asm'. Trying implicit prerequisite 'src/libavcodec/x86/SCCS/s.fpel.asm'. No implicit rule found for 'src/libavcodec/x86/fpel.asm'. Finished prerequisites of target file 'src/libavcodec/x86/fpel.asm= '. No need to remake target 'src/libavcodec/x86/fpel.asm'. Pruning file 'config.asm'. Pruning file 'src//libavutil/x86/x86util.asm'. Pruning file 'src//libavutil/x86/x86inc.asm'. Finished prerequisites of target file 'libavcodec/x86/fpel.o'. Prerequisite 'src/libavcodec/x86/fpel.c' of target 'libavcodec/x86/f= pel.o' does not exist. Prerequisite 'libavcodec/' is order-only for target 'libavcodec/x86/= fpel.o'. Prerequisite 'libavcodec/x86/' is order-only for target 'libavcodec/= x86/fpel.o'. Prerequisite 'src/libavcodec/x86/fpel.asm' is older than target 'lib= avcodec/x86/fpel.o'. Prerequisite 'config.asm' is newer than target 'libavcodec/x86/fpel.= o'. Prerequisite 'src//libavutil/x86/x86util.asm' is older than target '= libavcodec/x86/fpel.o'. Prerequisite 'src//libavutil/x86/x86inc.asm' is older than target 'l= ibavcodec/x86/fpel.o'. Must remake target 'libavcodec/x86/fpel.o'. Putting child 0x55fbfa094840 (libavcodec/x86/fpel.o) PID 29151 on the chain. Live child 0x55fbfa094840 (libavcodec/x86/fpel.o) PID 29151=20 CC libavcodec/x86/fpel.o x86_64-w64-mingw32-gcc: error: src/libavcodec/x86/fpel.c: No such file or d= irectory x86_64-w64-mingw32-gcc: fatal error: no input files compilation terminated. Reaping losing child 0x55fbfa094840 PID 29151=20 make: *** [libavcodec/x86/fpel.o] Error 1 src/ffbuild/common.mak:78: recipe for target 'libavcodec/x86/fpel.o' failed Removing child 0x55fbfa094840 PID 29151 from chain. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --QqoAFJW0Wwrf1M3c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYg1KKQAKCRBhHseHBAsP qzaMAJ0bFH4olLbMZGXlMOc2L977dbKSCACgjQ3hfHi44jaozK9Qhgc7eXZ2gVI= =ISfL -----END PGP SIGNATURE----- --QqoAFJW0Wwrf1M3c-- --===============4981087496822743136== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4981087496822743136==--