From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7957741211 for ; Tue, 15 Feb 2022 21:17:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 851A568B244; Tue, 15 Feb 2022 23:17:48 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 929B568B234 for ; Tue, 15 Feb 2022 23:17:41 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 14F5160004 for ; Tue, 15 Feb 2022 21:17:39 +0000 (UTC) Date: Tue, 15 Feb 2022 22:17:37 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220215211737.GK2829255@pb2> References: <20220215130517.25172-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/argo_cvg: Fix checksum X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6152181036613120072==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6152181036613120072== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KojRrsbczA2Vuv6e" Content-Disposition: inline --KojRrsbczA2Vuv6e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 16, 2022 at 12:25:52AM +1000, Zane van Iperen wrote: >=20 >=20 > On 15/2/22 23:05, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/argo_cvg.c | 15 +++++---------- > > libavformat/version.h | 2 +- > > 2 files changed, 6 insertions(+), 11 deletions(-) > >=20 > > diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c > > index c5da32536d..dfdf126c17 100644 > > --- a/libavformat/argo_cvg.c > > +++ b/libavformat/argo_cvg.c > > @@ -335,19 +335,14 @@ static int argo_cvg_write_trailer(AVFormatContext= *s) > > ArgoCVGMuxContext *ctx =3D s->priv_data; > > int64_t ret; > > + ctx->checksum +=3D (ctx->size & 255) > > + + ((ctx->size>> 8) & 255) > > + + ((ctx->size>>16) & 255) > > + + (ctx->size>>24); > > + >=20 > ...because of course it's that simple. How did I miss that? > No matter, lgtm! will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch --KojRrsbczA2Vuv6e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYgwYbQAKCRBhHseHBAsP q/MSAKCA9xqJJogxvWK/UTTj3TC2Nsg9SgCfe+RU5yBvf6G04VzYC7bcs94Lm3I= =KjgT -----END PGP SIGNATURE----- --KojRrsbczA2Vuv6e-- --===============6152181036613120072== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6152181036613120072==--