From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9466E411CF for ; Tue, 15 Feb 2022 13:37:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E696E68B219; Tue, 15 Feb 2022 15:37:29 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D094687992 for ; Tue, 15 Feb 2022 15:37:23 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 7C5D1C000C for ; Tue, 15 Feb 2022 13:37:22 +0000 (UTC) Date: Tue, 15 Feb 2022 14:37:21 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220215133721.GH2829255@pb2> References: <20220214193934.22315-1-michael@niedermayer.cc> <20220214193934.22315-2-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/movtextdec: add () to CMP() macro to avoid unexpected behavior X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0118481928742829064==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0118481928742829064== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rAP/hlYubCWfy1xM" Content-Disposition: inline --rAP/hlYubCWfy1xM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 14, 2022 at 08:52:52PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/movtextdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > > index 825632ca9b..dc30fdc698 100644 > > --- a/libavcodec/movtextdec.c > > +++ b/libavcodec/movtextdec.c > > @@ -263,7 +263,7 @@ static int decode_hclr(const uint8_t *tsmb, MovText= Context *m, uint64_t size) > > =20 > > static int styles_equivalent(const StyleBox *a, const StyleBox *b) > > { > > -#define CMP(field) a->field =3D=3D b->field > > +#define CMP(field) ((a)->field =3D=3D (b)->field) > > return CMP(bold) && CMP(italic) && CMP(underline) && CMP(color)= && > > CMP(alpha) && CMP(fontsize) && CMP(font_id); > > #undef CMP >=20 > LGTM. > (Did you find the issues in patches 2-4 by code inspection or by a > static analyzer?) some old grep commands [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you do not know the correct answe= r. --rAP/hlYubCWfy1xM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYgusjQAKCRBhHseHBAsP q1/mAJ9zFKRIKzhmth3uCqs0u2WnbrUN0ACeIefYHIlocQ58WIzHCVROKCdNwCI= =G9AV -----END PGP SIGNATURE----- --rAP/hlYubCWfy1xM-- --===============0118481928742829064== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0118481928742829064==--