From: lance.lmwang@gmail.com
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avutil: add support for CUVA HDR Vivid metadata
Date: Tue, 15 Feb 2022 15:24:07 +0800
Message-ID: <20220215072407.GA14120@gmail.com> (raw)
In-Reply-To: <AM7PR03MB666048C45568FEFB23AB6E598F349@AM7PR03MB6660.eurprd03.prod.outlook.com>
On Tue, Feb 15, 2022 at 08:08:51AM +0100, Andreas Rheinhardt wrote:
> lance.lmwang@gmail.com:
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> > libavutil/Makefile | 2 +
> > libavutil/frame.c | 1 +
> > libavutil/frame.h | 7 +
> > libavutil/hdr_dynamic_vivid_metadata.c | 47 ++++++
> > libavutil/hdr_dynamic_vivid_metadata.h | 285 +++++++++++++++++++++++++++++++++
> > libavutil/version.h | 2 +-
> > 6 files changed, 343 insertions(+), 1 deletion(-)
> > create mode 100644 libavutil/hdr_dynamic_vivid_metadata.c
> > create mode 100644 libavutil/hdr_dynamic_vivid_metadata.h
> >
> > diff --git a/libavutil/Makefile b/libavutil/Makefile
> > index d17876d..a8d7587 100644
> > --- a/libavutil/Makefile
> > +++ b/libavutil/Makefile
> > @@ -34,6 +34,7 @@ HEADERS = adler32.h \
> > frame.h \
> > hash.h \
> > hdr_dynamic_metadata.h \
> > + hdr_dynamic_vivid_metadata.h \
> > hmac.h \
> > hwcontext.h \
> > hwcontext_cuda.h \
> > @@ -130,6 +131,7 @@ OBJS = adler32.o \
> > frame.o \
> > hash.o \
> > hdr_dynamic_metadata.o \
> > + hdr_dynamic_vivid_metadata.o \
> > hmac.o \
> > hwcontext.o \
> > imgutils.o \
> > diff --git a/libavutil/frame.c b/libavutil/frame.c
> > index 8997c85..b035e28 100644
> > --- a/libavutil/frame.c
> > +++ b/libavutil/frame.c
> > @@ -723,6 +723,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
> > case AV_FRAME_DATA_SPHERICAL: return "Spherical Mapping";
> > case AV_FRAME_DATA_ICC_PROFILE: return "ICC profile";
> > case AV_FRAME_DATA_DYNAMIC_HDR_PLUS: return "HDR Dynamic Metadata SMPTE2094-40 (HDR10+)";
> > + case AV_FRAME_DATA_DYNAMIC_HDR_VIVID: return "HDR Dynamic Metadata CUVA 005.1 2021 (Vivid)";
> > case AV_FRAME_DATA_REGIONS_OF_INTEREST: return "Regions Of Interest";
> > case AV_FRAME_DATA_VIDEO_ENC_PARAMS: return "Video encoding parameters";
> > case AV_FRAME_DATA_SEI_UNREGISTERED: return "H.26[45] User Data Unregistered SEI message";
> > diff --git a/libavutil/frame.h b/libavutil/frame.h
> > index 18e239f..32cde3c 100644
> > --- a/libavutil/frame.h
> > +++ b/libavutil/frame.h
> > @@ -158,6 +158,13 @@ enum AVFrameSideDataType {
> > AV_FRAME_DATA_DYNAMIC_HDR_PLUS,
> >
> > /**
> > + * HDR Vivid dynamic metadata associated with a video frame. The payload is
> > + * an AVDynamicHDRVivid type and contains information for color
> > + * volume transform - CUVA 005.1-2021.
> > + */
> > + AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
> > +
>
> Always add at the end. You are breaking ABI otherwise.
Thanks for the comments, will fix it in the next version.
>
> > + /**
> > * Regions Of Interest, the data is an array of AVRegionOfInterest type, the number of
> > * array element is implied by AVFrameSideData.size / AVRegionOfInterest.self_size.
> > */
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-15 7:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 23:44 lance.lmwang
2022-02-14 23:44 ` [FFmpeg-devel] [PATCH 2/4] avcodec: " lance.lmwang
2022-02-14 23:44 ` [FFmpeg-devel] [PATCH 3/4] avfilter: " lance.lmwang
2022-02-14 23:44 ` [FFmpeg-devel] [PATCH 4/4] fftool/ffprobe: " lance.lmwang
2022-02-15 7:08 ` [FFmpeg-devel] [PATCH 1/4] avutil: add " Andreas Rheinhardt
2022-02-15 7:24 ` lance.lmwang [this message]
2022-02-26 6:11 ` lance.lmwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215072407.GA14120@gmail.com \
--to=lance.lmwang@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git