[FFmpeg-devel] [PATCH] avformat/gnutls: Use the systems default crypto policy

[FFmpeg-devel] [PATCH] avformat/gnutls: Use the systems default crypto policy

[Andreas Schneider]

We should use the systems crypto policy by default. If there is no
system policy, gnutls will use the "NORMAL" policy.

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
---
 libavformat/tls_gnutls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c
index 741578a596..2ab38a199b 100644
--- a/libavformat/tls_gnutls.c
+++ b/libavformat/tls_gnutls.c
@@ -192,7 +192,7 @@ static int tls_open(URLContext *h, const char *uri, int flags, AVDictionary **op
     gnutls_transport_set_pull_function(p->session, gnutls_url_pull);
     gnutls_transport_set_push_function(p->session, gnutls_url_push);
     gnutls_transport_set_ptr(p->session, p);
-    gnutls_priority_set_direct(p->session, "NORMAL", NULL);
+    gnutls_set_default_priority(p->session);
     do {
         if (ff_check_interrupt(&h->interrupt_callback)) {
             ret = AVERROR_EXIT;
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/gnutls: Use the systems default crypto policy

[Anton Khirnov]

Quoting Andreas Schneider (2022-02-11 08:34:14)
> We should use the systems crypto policy by default. If there is no
> system policy, gnutls will use the "NORMAL" policy.
> 
> Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
> ---
>  libavformat/tls_gnutls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c
> index 741578a596..2ab38a199b 100644
> --- a/libavformat/tls_gnutls.c
> +++ b/libavformat/tls_gnutls.c
> @@ -192,7 +192,7 @@ static int tls_open(URLContext *h, const char *uri, int flags, AVDictionary **op
>      gnutls_transport_set_pull_function(p->session, gnutls_url_pull);
>      gnutls_transport_set_push_function(p->session, gnutls_url_push);
>      gnutls_transport_set_ptr(p->session, p);
> -    gnutls_priority_set_direct(p->session, "NORMAL", NULL);
> +    gnutls_set_default_priority(p->session);
>      do {
>          if (ff_check_interrupt(&h->interrupt_callback)) {
>              ret = AVERROR_EXIT;

Looks reasonable, will push tomorrow if nobody objects.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".