Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 2/2] lavu/fifo: add a test for _cb functions
Date: Tue,  8 Feb 2022 19:26:14 +0100
Message-ID: <20220208182614.25504-2-anton@khirnov.net> (raw)
In-Reply-To: <20220208182614.25504-1-anton@khirnov.net>

Makes an auto-growing FIFO and performs a sequence of randomly-sized
writes/peeks/reads.
---
 libavutil/tests/fifo.c | 101 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 101 insertions(+)

diff --git a/libavutil/tests/fifo.c b/libavutil/tests/fifo.c
index 579602ccf3..bfcdfeebfb 100644
--- a/libavutil/tests/fifo.c
+++ b/libavutil/tests/fifo.c
@@ -18,7 +18,53 @@
 
 #include <stdio.h>
 #include <stdlib.h>
+#include "libavutil/common.h"
 #include "libavutil/fifo.h"
+#include "libavutil/lfg.h"
+#include "libavutil/random_seed.h"
+
+typedef struct CBState {
+    unsigned int read_idx;
+    unsigned int write_idx;
+    unsigned int to_process;
+    unsigned int offset;
+} CBState;
+
+static int read_cb(void *opaque, void *buf, size_t *nb_elems)
+{
+    CBState  *s = opaque;
+    unsigned *b = buf;
+
+    *nb_elems = FFMIN(*nb_elems, s->to_process);
+
+    for (unsigned i = 0; i < *nb_elems; i++)
+        if (b[i] != s->read_idx + s->offset + i) {
+            printf("Mismatch at idx %u offset %u i %u\n",
+                   s->read_idx, s->offset, i);
+            return AVERROR_BUG;
+        }
+
+    s->offset     += *nb_elems;
+    s->to_process -= *nb_elems;
+
+    return 0;
+}
+
+static int write_cb(void *opaque, void *buf, size_t *nb_elems)
+{
+    CBState  *s = opaque;
+    unsigned *b = buf;
+
+    *nb_elems = FFMIN(*nb_elems, s->to_process);
+
+    for (unsigned i = 0; i < *nb_elems; i++)
+        b[i] = s->write_idx + i;
+
+    s->write_idx  += *nb_elems;
+    s->to_process -= *nb_elems;
+
+    return 0;
+}
 
 int main(void)
 {
@@ -89,6 +135,61 @@ int main(void)
         printf("%d: %d\n", i, j);
     }
 
+    av_fifo_freep2(&fifo);
+
+    /* test randomly-sized write/read/peek with a callback */
+    {
+        CBState        s = { 0 };
+        uint32_t    seed = av_get_random_seed();
+
+        AVLFG lfg;
+        int ret;
+
+        av_lfg_init(&lfg, seed);
+
+        fifo = av_fifo_alloc2(1, sizeof(unsigned), AV_FIFO_FLAG_AUTO_GROW);
+
+        for (i = 0; i < 32; i++) {
+            size_t       nb_elems = 16;
+            unsigned   to_process = av_lfg_get(&lfg) % nb_elems;
+
+            s.to_process = to_process;
+
+            ret = av_fifo_write_from_cb(fifo, write_cb, &s, &nb_elems);
+            if (ret < 0 || s.to_process || nb_elems != to_process) {
+                printf("FIFO write fail; seed %"PRIu32"\n", seed);
+                return 1;
+            }
+
+            nb_elems = av_fifo_can_read(fifo);
+            if (nb_elems > 1) {
+                s.offset     = av_lfg_get(&lfg) % (nb_elems - 1);
+                nb_elems    -= s.offset;
+
+                s.to_process = av_lfg_get(&lfg) % nb_elems;
+                to_process   = s.to_process;
+
+                ret = av_fifo_peek_to_cb(fifo, read_cb, &s, &nb_elems, s.offset);
+                if (ret < 0 || s.to_process || nb_elems != to_process) {
+                    printf("FIFO peek fail; seed %"PRIu32"\n", seed);
+                    return 1;
+                }
+            }
+
+            nb_elems     = av_fifo_can_read(fifo);
+            to_process   = nb_elems ? av_lfg_get(&lfg) % nb_elems : 0;
+            s.to_process = to_process;
+            s.offset     = 0;
+
+            ret = av_fifo_read_to_cb(fifo, read_cb, &s, &nb_elems);
+            if (ret < 0 || s.to_process || to_process != nb_elems) {
+                printf("FIFO peek fail; seed %"PRIu32"\n", seed);
+                return 1;
+            }
+            s.read_idx += s.offset;
+        }
+    }
+
     av_fifo_freep2(&fifo);
     free(p);
 
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-02-08 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 18:26 [FFmpeg-devel] [PATCH 1/2] lavu/fifo: fix a corner case in av_fifo_grow2() Anton Khirnov
2022-02-08 18:26 ` Anton Khirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220208182614.25504-2-anton@khirnov.net \
    --to=anton@khirnov.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git