From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C312D40AA0 for ; Thu, 3 Feb 2022 14:54:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C8AE468B072; Thu, 3 Feb 2022 16:54:07 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 56C3D68AAC1 for ; Thu, 3 Feb 2022 16:54:02 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 87950C0016 for ; Thu, 3 Feb 2022 14:54:01 +0000 (UTC) Date: Thu, 3 Feb 2022 15:54:00 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220203145400.GQ2829255@pb2> References: <20220201215830.65635-1-markg85@gmail.com> <20220201215830.65635-2-markg85@gmail.com> <20220202132918.GN2829255@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6698447683943460479==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6698447683943460479== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="I0JUXUhnehxKnLt4" Content-Disposition: inline --I0JUXUhnehxKnLt4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 02, 2022 at 03:23:34PM +0100, Mark Gaiser wrote: > On Wed, Feb 2, 2022 at 2:29 PM Michael Niedermayer > wrote: >=20 > > On Tue, Feb 01, 2022 at 10:58:30PM +0100, Mark Gaiser wrote: [...] > > > > > > > + AVClass *class; > > > + URLContext *inner; > > > + char *gateway; > > > +} Context; > > > + > > > +// A best-effort way to find the IPFS gateway. > > > +// Only the most appropiate gateway is set. It's not actually reques= ted > > (http call) to prevent > > > +// a potential slowdown in startup. A potential timeout is handled by > > the HTTP protocol. > > > +// > > > +// When done and the return value is 1, a potential IPFS Gateway is = set > > in the gateway > > > +// variable in the inner URLContext. > > > > > +static int ff_populate_ipfs_gateway(URLContext *h) > > > > ff_ prefix seems not needed > > >=20 > Done. Removed the prefix from both functions. > For the record, I thought it was mandatory to prefix internal functions > with "ff_"? only non static ones, these prefixes are to avoid conflicing with other things in the global namespace [...] >=20 >=20 > > > > > > > + } > > > + > > > > > + fscanf(gateway_file, "%[^\n]", gateway_file_data); > > > > how large is the array ? > > how large is the data written into the array ? > > what is the relation between the 2 ? > > >=20 > Yeah... I'm going to need more information on that one. > What do you mean? > Is this wrong? the array is fixed length, the string written into it is from some external file IIRC.=20 Maybe i missed a check but to me it seemed like the array end can be overwritten which is bad thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt. --I0JUXUhnehxKnLt4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYfvshQAKCRBhHseHBAsP qwz1AJ0RJ4xSCwU5UhfGjh2P9/LmtRBLmgCdGwLKOFDU923jJxqS7OWo1FHr3pA= =kMW8 -----END PGP SIGNATURE----- --I0JUXUhnehxKnLt4-- --===============6698447683943460479== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6698447683943460479==--