From: Vittorio Giovara <vittorio.giovara@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 2/2] http: Send a Range header even when the offset is 0 Date: Thu, 3 Feb 2022 00:49:53 +0100 Message-ID: <20220202234953.6337-2-vittorio.giovara@gmail.com> (raw) In-Reply-To: <20220202234953.6337-1-vittorio.giovara@gmail.com> From: Justin Ruggles <justin.ruggles@gmail.com> Using Range allows for getting the full file size from the Content-Range header in the response, even if the server sends back the response using chunked Transfer-Encoding, which does not allow using Content-Length. --- libavformat/http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index c89f8a5517..c79db955e8 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1469,10 +1469,10 @@ static int http_connect(URLContext *h, const char *path, const char *local_path, } if (!has_header(s->headers, "\r\nAccept: ")) av_bprintf(&request, "Accept: */*\r\n"); - // Note: we send this on purpose even when s->off is 0 when we're probing, + // Note: we send the Range header on purpose, even when we're probing, // since it allows us to detect more reliably if a (non-conforming) // server supports seeking by analysing the reply headers. - if (!has_header(s->headers, "\r\nRange: ") && !post && (s->off > 0 || s->end_off || s->seekable == -1)) { + if (!has_header(s->headers, "\r\nRange: ") && !post && (s->off > 0 || s->end_off || s->seekable != 0)) { av_bprintf(&request, "Range: bytes=%"PRIu64"-", s->off); if (s->end_off) av_bprintf(&request, "%"PRId64, s->end_off - 1); -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-02 23:50 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-02 23:49 [FFmpeg-devel] [PATCH 1/2] http: Improve handling of Content-Range with Transfer-Encoding:chunked Vittorio Giovara 2022-02-02 23:49 ` Vittorio Giovara [this message] 2022-02-03 1:26 ` Aman Karmani 2022-02-03 14:12 ` Derek Buitenhuis 2022-02-09 0:55 ` Vittorio Giovara 2022-02-09 8:49 ` Paul B Mahol 2022-02-11 12:02 ` Vittorio Giovara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220202234953.6337-2-vittorio.giovara@gmail.com \ --to=vittorio.giovara@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git