From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4316D4094C for ; Tue, 1 Feb 2022 18:47:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B9DB268B48B; Tue, 1 Feb 2022 20:47:47 +0200 (EET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E8D3368B360 for ; Tue, 1 Feb 2022 20:47:40 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 7E57D100003 for ; Tue, 1 Feb 2022 18:47:39 +0000 (UTC) Date: Tue, 1 Feb 2022 19:47:38 +0100 From: Michael Niedermayer To: ffmpeg-devel@ffmpeg.org Message-ID: <20220201184738.GE2978559@pb2> References: <20220116051916.342B441047A@natalya.videolan.org> MIME-Version: 1.0 In-Reply-To: <20220116051916.342B441047A@natalya.videolan.org> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mpegts: add option max_packet_size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6547436630799668534==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6547436630799668534== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XIiC+We3v3zHqZ6Z" Content-Disposition: inline --XIiC+We3v3zHqZ6Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 16, 2022 at 05:19:15AM +0000, Gyan Doshi wrote: > ffmpeg | branch: master | Gyan Doshi | Wed Jan 12 20:5= 7:59 2022 +0530| [bca30570d28bbaa07badadabf55ec3589201a82f] | committer: Gy= an Doshi >=20 > avformat/mpegts: add option max_packet_size >=20 > Makes maximum size of emitted packet user-tunable. >=20 > Default is existing 204800 bytes. >=20 > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3Dbca30570d= 28bbaa07badadabf55ec3589201a82f > --- >=20 > doc/demuxers.texi | 4 ++++ > libavformat/mpegts.c | 11 ++++++----- > 2 files changed, 10 insertions(+), 5 deletions(-) Since this commit there is occasional memory corruption occuring libavutil 57. 18.100 / 57. 18.100 libavcodec 59. 20.100 / 59. 20.100 libavformat 59. 17.101 / 59. 17.101 libavdevice 59. 5.100 / 59. 5.100 libavfilter 8. 25.100 / 8. 25.100 libswscale 6. 5.100 / 6. 5.100 libswresample 4. 4.100 / 4. 4.100 libpostproc 56. 4.100 / 56. 4.100 invalid fastbin entry (free) doom/rtp-video: line 14: 15621 Aborted (core dumped) ./ffmp= eg_g -bitexact -protocol_whitelist http,tcp,rtp,udp -i http://127.0.0.1:808= 0/test.sdp -bitexact -acodec mp2 -ab 64k -y -t 1 -threads 1 $TMP/out.avi Command exited with non-zero status 134 this was tricky to reproduce under a memory debugger as it dependat on timi= ng but heres a run that crashed under valgrind the input was generated with this: (and some tuned delays) =2E/ffmpeg -bitexact -i ~/videos/mm-short.mpg -y -s 320x240 -bitexact -t 1= 0 -threads 1 $TMP/in.mpg cvlc --play-and-exit -vvv $TMP/in.mpg --sout '#rtp{dst=3D127.0.0.1,port=3D5= 104,mux=3Dts,sdp=3Dhttp://127.0.0.1:8076/test.sdp}' =3D=3D17945=3D=3D Invalid write of size 2 =3D=3D17945=3D=3D at 0x4C38753: memmove (in /usr/lib/valgrind/vgpreload_= memcheck-amd64-linux.so) =3D=3D17945=3D=3D by 0x6A6650: mpegts_push_data (mpegts.c:1397) =3D=3D17945=3D=3D by 0x6AB60E: handle_packet (mpegts.c:2879) =3D=3D17945=3D=3D by 0x6AD048: avpriv_mpegts_parse_packet (mpegts.c:3407) =3D=3D17945=3D=3D by 0x7AFA06: mpegts_handle_packet (rtpdec_mpegts.c:77) =3D=3D17945=3D=3D by 0x7A7BFA: rtp_parse_packet_internal (rtpdec.c:762) =3D=3D17945=3D=3D by 0x7A8211: rtp_parse_one_packet (rtpdec.c:900) =3D=3D17945=3D=3D by 0x7A83A7: ff_rtp_parse_packet (rtpdec.c:945) =3D=3D17945=3D=3D by 0x71D4B5: ff_rtsp_fetch_packet (rtsp.c:2273) =3D=3D17945=3D=3D by 0x5DB6E8: ff_read_packet (demux.c:557) =3D=3D17945=3D=3D by 0x5DE6D8: read_frame_internal (demux.c:1231) =3D=3D17945=3D=3D by 0x5E3CB4: avformat_find_stream_info (demux.c:2584) =3D=3D17945=3D=3D Address 0x16a730c0 is 0 bytes after a block of size 64 a= lloc'd =3D=3D17945=3D=3D at 0x4C33E76: memalign (in /usr/lib/valgrind/vgpreload= _memcheck-amd64-linux.so) =3D=3D17945=3D=3D by 0x4C33F91: posix_memalign (in /usr/lib/valgrind/vgp= reload_memcheck-amd64-linux.so) =3D=3D17945=3D=3D by 0x129949B: av_malloc (mem.c:104) =3D=3D17945=3D=3D by 0x127F3AE: av_buffer_alloc (buffer.c:82) =3D=3D17945=3D=3D by 0x127FDF6: pool_alloc_buffer (buffer.c:365) =3D=3D17945=3D=3D by 0x127FF77: av_buffer_pool_get (buffer.c:404) =3D=3D17945=3D=3D by 0x6A5955: buffer_pool_get (mpegts.c:1130) =3D=3D17945=3D=3D by 0x6A65F5: mpegts_push_data (mpegts.c:1392) =3D=3D17945=3D=3D by 0x6AB60E: handle_packet (mpegts.c:2879) =3D=3D17945=3D=3D by 0x6AD048: avpriv_mpegts_parse_packet (mpegts.c:3407) =3D=3D17945=3D=3D by 0x7AFA06: mpegts_handle_packet (rtpdec_mpegts.c:77) =3D=3D17945=3D=3D by 0x7A7BFA: rtp_parse_packet_internal (rtpdec.c:762) =3D=3D17945=3D=3D=20 --17945-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) = - exiting --17945-- si_code=3D128; Faulting address: 0x0; sp: 0x10032c1e20 valgrind: the 'impossible' happened: Killed by fatal signal host stacktrace: =3D=3D17945=3D=3D at 0x58051665: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D17945=3D=3D by 0x58053E58: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D17945=3D=3D by 0x5800BA44: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D17945=3D=3D by 0x5800BD64: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D17945=3D=3D by 0x5809F55C: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D17945=3D=3D by 0x580AECD0: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) sched status: running_tid=3D1 Thread 1: status =3D VgTs_Runnable (lwpid 17945) =3D=3D17945=3D=3D at 0x4C33E76: memalign (in /usr/lib/valgrind/vgpreload= _memcheck-amd64-linux.so) =3D=3D17945=3D=3D by 0x4C33F91: posix_memalign (in /usr/lib/valgrind/vgp= reload_memcheck-amd64-linux.so) =3D=3D17945=3D=3D by 0x129949B: av_malloc (mem.c:104) =3D=3D17945=3D=3D by 0x12998EE: av_mallocz (mem.c:265) =3D=3D17945=3D=3D by 0x6A671C: add_pes_stream (mpegts.c:1428) =3D=3D17945=3D=3D by 0x6AB01D: handle_packet (mpegts.c:2761) =3D=3D17945=3D=3D by 0x6AD048: avpriv_mpegts_parse_packet (mpegts.c:3407) =3D=3D17945=3D=3D by 0x7AFA06: mpegts_handle_packet (rtpdec_mpegts.c:77) =3D=3D17945=3D=3D by 0x7A7BFA: rtp_parse_packet_internal (rtpdec.c:762) =3D=3D17945=3D=3D by 0x7A8292: rtp_parse_one_packet (rtpdec.c:911) =3D=3D17945=3D=3D by 0x7A83A7: ff_rtp_parse_packet (rtpdec.c:945) =3D=3D17945=3D=3D by 0x71D4B5: ff_rtsp_fetch_packet (rtsp.c:2273) =3D=3D17945=3D=3D by 0x5DB6E8: ff_read_packet (demux.c:557) =3D=3D17945=3D=3D by 0x5DE6D8: read_frame_internal (demux.c:1231) =3D=3D17945=3D=3D by 0x5E3CB4: avformat_find_stream_info (demux.c:2584) =3D=3D17945=3D=3D by 0x232DB0: open_input_file (ffmpeg_opt.c:1200) =3D=3D17945=3D=3D by 0x241D56: open_files (ffmpeg_opt.c:3423) =3D=3D17945=3D=3D by 0x241F0A: ffmpeg_parse_options (ffmpeg_opt.c:3463) =3D=3D17945=3D=3D by 0x261331: main (ffmpeg.c:4870) heres the same with origin/master libavutil 57. 19.100 / 57. 19.100 libavcodec 59. 20.100 / 59. 20.100 libavformat 59. 17.101 / 59. 17.101 libavdevice 59. 5.100 / 59. 5.100 libavfilter 8. 26.101 / 8. 26.101 libswscale 6. 5.100 / 6. 5.100 libswresample 4. 4.100 / 4. 4.100 libpostproc 56. 4.100 / 56. 4.100 =3D=3D11758=3D=3D Invalid write of size 2 =3D=3D11758=3D=3D at 0x4C38753: memmove (in /usr/lib/valgrind/vgpreload_= memcheck-amd64-linux.so) =3D=3D11758=3D=3D by 0x6AB497: mpegts_push_data (mpegts.c:1397) =3D=3D11758=3D=3D by 0x6B0455: handle_packet (mpegts.c:2879) =3D=3D11758=3D=3D by 0x6B1E8F: avpriv_mpegts_parse_packet (mpegts.c:3407) =3D=3D11758=3D=3D by 0x7B4BE8: mpegts_handle_packet (rtpdec_mpegts.c:77) =3D=3D11758=3D=3D by 0x7ACD85: rtp_parse_packet_internal (rtpdec.c:762) =3D=3D11758=3D=3D by 0x7AD3AF: rtp_parse_one_packet (rtpdec.c:905) =3D=3D11758=3D=3D by 0x7AD545: ff_rtp_parse_packet (rtpdec.c:950) =3D=3D11758=3D=3D by 0x722419: ff_rtsp_fetch_packet (rtsp.c:2273) =3D=3D11758=3D=3D by 0x5DF675: ff_read_packet (demux.c:557) =3D=3D11758=3D=3D by 0x5E2665: read_frame_internal (demux.c:1231) =3D=3D11758=3D=3D by 0x5E7C41: avformat_find_stream_info (demux.c:2584) =3D=3D11758=3D=3D Address 0x16a72fc0 is 0 bytes after a block of size 64 a= lloc'd =3D=3D11758=3D=3D at 0x4C33E76: memalign (in /usr/lib/valgrind/vgpreload= _memcheck-amd64-linux.so) =3D=3D11758=3D=3D by 0x4C33F91: posix_memalign (in /usr/lib/valgrind/vgp= reload_memcheck-amd64-linux.so) =3D=3D11758=3D=3D by 0x128E3AB: av_malloc (mem.c:104) =3D=3D11758=3D=3D by 0x12742BE: av_buffer_alloc (buffer.c:82) =3D=3D11758=3D=3D by 0x1274D06: pool_alloc_buffer (buffer.c:365) =3D=3D11758=3D=3D by 0x1274E87: av_buffer_pool_get (buffer.c:404) =3D=3D11758=3D=3D by 0x6AA79C: buffer_pool_get (mpegts.c:1130) =3D=3D11758=3D=3D by 0x6AB43C: mpegts_push_data (mpegts.c:1392) =3D=3D11758=3D=3D by 0x6B0455: handle_packet (mpegts.c:2879) =3D=3D11758=3D=3D by 0x6B1E8F: avpriv_mpegts_parse_packet (mpegts.c:3407) =3D=3D11758=3D=3D by 0x7B4BE8: mpegts_handle_packet (rtpdec_mpegts.c:77) =3D=3D11758=3D=3D by 0x7ACD85: rtp_parse_packet_internal (rtpdec.c:762) =3D=3D11758=3D=3D=20 --11758-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) = - exiting --11758-- si_code=3D128; Faulting address: 0x0; sp: 0x10032c6e20 valgrind: the 'impossible' happened: Killed by fatal signal host stacktrace: =3D=3D11758=3D=3D at 0x58051665: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D11758=3D=3D by 0x58053E58: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D11758=3D=3D by 0x5800BA44: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D11758=3D=3D by 0x5800BD64: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D11758=3D=3D by 0x5809F55C: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) =3D=3D11758=3D=3D by 0x580AECD0: ??? (in /usr/lib/valgrind/memcheck-amd6= 4-linux) sched status: running_tid=3D1 Thread 1: status =3D VgTs_Runnable (lwpid 11758) =3D=3D11758=3D=3D at 0x4C33E76: memalign (in /usr/lib/valgrind/vgpreload= _memcheck-amd64-linux.so) =3D=3D11758=3D=3D by 0x4C33F91: posix_memalign (in /usr/lib/valgrind/vgp= reload_memcheck-amd64-linux.so) =3D=3D11758=3D=3D by 0x128E3AB: av_malloc (mem.c:104) =3D=3D11758=3D=3D by 0x128E7FE: av_mallocz (mem.c:265) =3D=3D11758=3D=3D by 0x6AB563: add_pes_stream (mpegts.c:1428) =3D=3D11758=3D=3D by 0x6AFE64: handle_packet (mpegts.c:2761) =3D=3D11758=3D=3D by 0x6B1E8F: avpriv_mpegts_parse_packet (mpegts.c:3407) =3D=3D11758=3D=3D by 0x7B4BE8: mpegts_handle_packet (rtpdec_mpegts.c:77) =3D=3D11758=3D=3D by 0x7ACD85: rtp_parse_packet_internal (rtpdec.c:762) =3D=3D11758=3D=3D by 0x7AD430: rtp_parse_one_packet (rtpdec.c:916) =3D=3D11758=3D=3D by 0x7AD545: ff_rtp_parse_packet (rtpdec.c:950) =3D=3D11758=3D=3D by 0x722419: ff_rtsp_fetch_packet (rtsp.c:2273) =3D=3D11758=3D=3D by 0x5DF675: ff_read_packet (demux.c:557) =3D=3D11758=3D=3D by 0x5E2665: read_frame_internal (demux.c:1231) =3D=3D11758=3D=3D by 0x5E7C41: avformat_find_stream_info (demux.c:2584) =3D=3D11758=3D=3D by 0x235E10: open_input_file (ffmpeg_opt.c:1200) =3D=3D11758=3D=3D by 0x244DB6: open_files (ffmpeg_opt.c:3423) =3D=3D11758=3D=3D by 0x244F6A: ffmpeg_parse_options (ffmpeg_opt.c:3463) =3D=3D11758=3D=3D by 0x264391: main (ffmpeg.c:4870) [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato --XIiC+We3v3zHqZ6Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYfmARgAKCRBhHseHBAsP q1f/AJ98nxOSM6RTKYiUNficFOVs3H4WOACeI6lPzUYzVUGHCHQDTAZvqHoPd7Y= =z70x -----END PGP SIGNATURE----- --XIiC+We3v3zHqZ6Z-- --===============6547436630799668534== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6547436630799668534==--