From: Mark Gaiser <markg85@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Mark Gaiser <markg85@gmail.com>
Subject: [FFmpeg-devel] [PATCH 5/5] Fix review feedback
Date: Mon, 31 Jan 2022 14:51:16 +0100
Message-ID: <20220131135116.14035-6-markg85@gmail.com> (raw)
In-Reply-To: <20220131135116.14035-1-markg85@gmail.com>
Little bit of consistency in punctuations.
Signed-off-by: Mark Gaiser <markg85@gmail.com>
---
libavformat/ipfs.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavformat/ipfs.c b/libavformat/ipfs.c
index 8f6f91d85d..1644c74eac 100644
--- a/libavformat/ipfs.c
+++ b/libavformat/ipfs.c
@@ -46,7 +46,7 @@ typedef struct Context {
// A best-effort way to find the IPFS gateway.
// Only the most appropiate gateway is set. It's not actually requested (http call) to prevent
-// potential slowdown in startup. A potential timeout is handled by the HTTP protocol.
+// a potential slowdown in startup. A potential timeout is handled by the HTTP protocol.
//
// When done and the return value is 1, a potential IPFS Gateway is set in the gateway
// variable in the inner URLContext.
@@ -68,7 +68,7 @@ static int populate_ipfs_gateway(URLContext *h)
return 1;
}
- // Test $IPFS_GATEWAY
+ // Test $IPFS_GATEWAY.
c->gateway = getenv("IPFS_GATEWAY");
if (c->gateway) {
return 1;
@@ -82,7 +82,7 @@ static int populate_ipfs_gateway(URLContext *h)
if (!ipfs_full_data_folder) {
av_log(h, AV_LOG_DEBUG, "$IPFS_PATH is empty.\n");
- // Try via the home folder
+ // Try via the home folder.
home_folder = getenv("HOME");
ipfs_full_data_folder = malloc(strlen(home_folder) + strlen(ipfs_data_folder) + 1);
strcpy(ipfs_full_data_folder, home_folder);
@@ -117,7 +117,7 @@ static int populate_ipfs_gateway(URLContext *h)
return -1;
}
- // Get the contents of the gateway file
+ // Get the contents of the gateway file.
gateway_file = av_fopen_utf8(ipfs_gateway_file, "r");
if (!gateway_file) {
av_log(h, AV_LOG_ERROR, "Unable to open the IPFS gateway file (full uri: %s).\n", ipfs_gateway_file);
@@ -132,7 +132,7 @@ static int populate_ipfs_gateway(URLContext *h)
return -1;
}
- // Copy the gateway url into c->gateway
+ // Copy the gateway url into c->gateway.
c->gateway = malloc(strlen(gateway_file_data) + 1);
strcpy(c->gateway, gateway_file_data);
if (c->gateway) {
@@ -194,7 +194,7 @@ static int ipfs_open(URLContext *h, const char *uri, int flags, AVDictionary **o
goto err;
}
- // If we have IPNS, update the protocol
+ // If we have IPNS, update the protocol.
if (is_ipns) {
protocol_path_suffix = "ipns/";
}
--
2.35.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-31 13:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 13:51 [FFmpeg-devel] [PATCH 0/5] Add IPFS and IPNS protocol support Mark Gaiser
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 1/5] Early version of IPFS " Mark Gaiser
2022-01-31 15:59 ` Michael Niedermayer
2022-01-31 16:06 ` James Almer
2022-01-31 16:34 ` Mark Gaiser
2022-01-31 20:26 ` Lynne
2022-01-31 22:04 ` Mark Gaiser
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 2/5] Fix up IPNS support Mark Gaiser
2022-01-31 16:00 ` Michael Niedermayer
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 3/5] Merge IPNS and IPFS handling Mark Gaiser
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 4/5] Implement logic to determine the IPFS gateway Mark Gaiser
2022-01-31 13:51 ` Mark Gaiser [this message]
2022-01-31 15:46 ` [FFmpeg-devel] [PATCH 5/5] Fix review feedback Michael Niedermayer
2022-01-31 16:33 ` Mark Gaiser
2022-01-31 15:52 ` [FFmpeg-devel] [PATCH 0/5] Add IPFS and IPNS protocol support Tomas Härdin
2022-01-31 16:31 ` Mark Gaiser
2022-01-31 20:22 ` Tomas Härdin
2022-01-31 22:00 ` Mark Gaiser
2022-02-01 16:39 ` Tomas Härdin
2022-02-01 21:18 ` Mark Gaiser
2022-02-02 12:51 ` Tomas Härdin
2022-02-02 13:32 ` Mark Gaiser
2022-02-01 10:06 ` Michael Niedermayer
2022-02-01 16:43 ` Tomas Härdin
2022-02-02 13:48 ` Michael Niedermayer
2022-02-04 10:28 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131135116.14035-6-markg85@gmail.com \
--to=markg85@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git