From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8D86140784 for ; Sun, 30 Jan 2022 11:40:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F115E68B149; Sun, 30 Jan 2022 13:40:55 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B2C4A68B0BC for ; Sun, 30 Jan 2022 13:40:48 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 0E99020004 for ; Sun, 30 Jan 2022 11:40:46 +0000 (UTC) Date: Sun, 30 Jan 2022 12:40:46 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220130114046.GD2829255@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 16/41] avcodec/mpegvideo: Use typedefs for MPV(Main)?(Dec|Enc)?Context X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8824788829292155225==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8824788829292155225== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YHBIftYJm1lggWxJ" Content-Disposition: inline --YHBIftYJm1lggWxJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 30, 2022 at 07:27:24AM +0100, Andreas Rheinhardt wrote: > This is in preparation for actually adding such contexts > and e.g. moving fields only used by the main thread to > the corresponding "Main" context. >=20 > Signed-off-by: Andreas Rheinhardt This breaks build on mingw64 src/libavcodec/dxva2_mpeg2.c:42:50: warning: =E2=80=98struct MPVDecContext= =E2=80=99 declared inside parameter list will not be visible outside of thi= s definition or declaration const struct MPVDecContext *s, ^~~~~~~~~~~~~ src/libavcodec/dxva2_mpeg2.c: In function =E2=80=98fill_picture_parameters= =E2=80=99: src/libavcodec/dxva2_mpeg2.c:45:39: error: dereferencing pointer to incompl= ete type =E2=80=98const struct MPVDecContext=E2=80=99 const Picture *current_picture =3D s->current_picture_ptr; ^~ src/libavcodec/dxva2_mpeg2.c: At top level: src/libavcodec/dxva2_mpeg2.c:108:53: warning: =E2=80=98struct MPVDecContext= =E2=80=99 declared inside parameter list will not be visible outside of thi= s definition or declaration const struct MPVDecContext *s, ^~~~~~~~~~~~~ src/libavcodec/dxva2_mpeg2.c: In function =E2=80=98fill_quantization_matric= es=E2=80=99: src/libavcodec/dxva2_mpeg2.c:115:18: error: dereferencing pointer to incomp= lete type =E2=80=98const struct MPVDecContext=E2=80=99 int n =3D s->idsp.idct_permutation[ff_zigzag_direct[i]]; ^~ src/libavcodec/dxva2_mpeg2.c:115:13: warning: variable =E2=80=98n=E2=80=99 = set but not used [-Wunused-but-set-variable] int n =3D s->idsp.idct_permutation[ff_zigzag_direct[i]]; ^ src/libavcodec/dxva2_mpeg2.c: At top level: src/libavcodec/dxva2_mpeg2.c:124:37: warning: =E2=80=98struct MPVDecContext= =E2=80=99 declared inside parameter list will not be visible outside of thi= s definition or declaration const struct MPVDecContext *s, ^~~~~~~~~~~~~ src/libavcodec/dxva2_mpeg2.c: In function =E2=80=98fill_slice=E2=80=99: src/libavcodec/dxva2_mpeg2.c:129:21: error: dereferencing pointer to incomp= lete type =E2=80=98const struct MPVDecContext=E2=80=99 int is_field =3D s->picture_structure !=3D PICT_FRAME; ^~ src/libavcodec/dxva2_mpeg2.c: In function =E2=80=98commit_bitstream_and_sli= ce_buffer=E2=80=99: src/libavcodec/dxva2_mpeg2.c:157:10: error: dereferencing pointer to incomp= lete type =E2=80=98const struct MPVDecContext=E2=80=99 s->current_picture_ptr->hwaccel_picture_private; ^~ src/libavcodec/dxva2_mpeg2.c: In function =E2=80=98dxva2_mpeg2_start_frame= =E2=80=99: src/libavcodec/dxva2_mpeg2.c:260:10: error: dereferencing pointer to incomp= lete type =E2=80=98const struct MPVDecContext=E2=80=99 s->current_picture_ptr->hwaccel_picture_private; ^~ src/libavcodec/dxva2_mpeg2.c:266:41: warning: passing argument 3 of =E2=80= =98fill_picture_parameters=E2=80=99 from incompatible pointer type [-Wincom= patible-pointer-types] fill_picture_parameters(avctx, ctx, s, &ctx_pic->pp); ^ src/libavcodec/dxva2_mpeg2.c:40:13: note: expected =E2=80=98const struct MP= VDecContext *=E2=80=99 but argument is of type =E2=80=98const struct MPVDec= Context * const=E2=80=99 static void fill_picture_parameters(AVCodecContext *avctx, ^~~~~~~~~~~~~~~~~~~~~~~ src/libavcodec/dxva2_mpeg2.c:267:44: warning: passing argument 3 of =E2=80= =98fill_quantization_matrices=E2=80=99 from incompatible pointer type [-Win= compatible-pointer-types] fill_quantization_matrices(avctx, ctx, s, &ctx_pic->qm); ^ src/libavcodec/dxva2_mpeg2.c:106:13: note: expected =E2=80=98const struct M= PVDecContext *=E2=80=99 but argument is of type =E2=80=98const struct MPVDe= cContext * const=E2=80=99 static void fill_quantization_matrices(AVCodecContext *avctx, ^~~~~~~~~~~~~~~~~~~~~~~~~~ src/libavcodec/dxva2_mpeg2.c: In function =E2=80=98dxva2_mpeg2_decode_slice= =E2=80=99: src/libavcodec/dxva2_mpeg2.c:280:10: error: dereferencing pointer to incomp= lete type =E2=80=98const struct MPVDecContext=E2=80=99 s->current_picture_ptr->hwaccel_picture_private; ^~ src/libavcodec/dxva2_mpeg2.c:293:23: warning: passing argument 2 of =E2=80= =98fill_slice=E2=80=99 from incompatible pointer type [-Wincompatible-point= er-types] fill_slice(avctx, s, &ctx_pic->slice[ctx_pic->slice_count++], position, ^ src/libavcodec/dxva2_mpeg2.c:123:13: note: expected =E2=80=98const struct M= PVDecContext *=E2=80=99 but argument is of type =E2=80=98const struct MPVDe= cContext * const=E2=80=99 static void fill_slice(AVCodecContext *avctx, ^~~~~~~~~~ src/libavcodec/dxva2_mpeg2.c: In function =E2=80=98dxva2_mpeg2_end_frame=E2= =80=99: src/libavcodec/dxva2_mpeg2.c:302:10: error: dereferencing pointer to incomp= lete type =E2=80=98struct MPVDecContext=E2=80=99 s->current_picture_ptr->hwaccel_picture_private; ^~ src/libavcodec/dxva2_mpeg2.c:312:33: warning: passing argument 1 of =E2=80= =98ff_mpeg_draw_horiz_band=E2=80=99 from incompatible pointer type [-Wincom= patible-pointer-types] ff_mpeg_draw_horiz_band(s, 0, avctx->height); ^ In file included from src/libavcodec/dxva2_mpeg2.c:27:0: src/libavcodec/mpegvideo.h:606:6: note: expected =E2=80=98MPVContext * {aka= struct MPVContext *}=E2=80=99 but argument is of type =E2=80=98struct MPVD= ecContext * const=E2=80=99 void ff_mpeg_draw_horiz_band(MPVContext *s, int y, int h); ^~~~~~~~~~~~~~~~~~~~~~~ src/ffbuild/common.mak:78: recipe for target 'libavcodec/dxva2_mpeg2.o' fai= led make: *** [libavcodec/dxva2_mpeg2.o] Error 1 make: *** Waiting for unfinished jobs.... [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time. --YHBIftYJm1lggWxJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYfZ5OgAKCRBhHseHBAsP q2EXAJsHqCq6gdnXeujgvyvhdF+O54yYBwCePd7JLqypgJN4h8oLnFMm8+4O8Uc= =ByWZ -----END PGP SIGNATURE----- --YHBIftYJm1lggWxJ-- --===============8824788829292155225== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8824788829292155225==--