Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH 2/3] avfilter/af_apsyclip: fix peak overestimation
@ 2022-01-29  1:12 Jason Jang
  0 siblings, 0 replies; only message in thread
From: Jason Jang @ 2022-01-29  1:12 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Jason Jang

Ignore more samples that are near the edge of the block. The reason
is that the filtering tends to cause these samples to go above the
window more than the samples near the middle. If these samples are
included in the unwindowed peak estimation, the peak can be
overestimated. Because the block is windowed again before
overlapping, overshoots near the edge of the block are not very
important.

0.1 is the value from the version originally contributed to calf.

Signed-off-by: Jason Jang <jcj83429@gmail.com>
---
 libavfilter/af_apsyclip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/af_apsyclip.c b/libavfilter/af_apsyclip.c
index 0bc469c..2a79ed3 100644
--- a/libavfilter/af_apsyclip.c
+++ b/libavfilter/af_apsyclip.c
@@ -87,7 +87,7 @@ static void generate_hann_window(float *window, float *inv_window, int size)
 
         window[i] = value;
         // 1/window to calculate unwindowed peak.
-        inv_window[i] = value > 0.01f ? 1.f / value : 0.f;
+        inv_window[i] = value > 0.1f ? 1.f / value : 0.f;
     }
 }
 
-- 
2.35.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-29  1:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29  1:12 [FFmpeg-devel] [PATCH 2/3] avfilter/af_apsyclip: fix peak overestimation Jason Jang

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git