From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 2/2] libavutil/random_seed: Skip testing generic seed twice
Date: Tue, 25 Jan 2022 11:21:09 +0100
Message-ID: <20220125102109.522-2-michael@niedermayer.cc> (raw)
In-Reply-To: <20220125102109.522-1-michael@niedermayer.cc>
If no platform specific random seed is supported then the generic code
was tested twice, this is unneeded
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavutil/random_seed.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c
index 509b74936c..a8be2d4991 100644
--- a/libavutil/random_seed.c
+++ b/libavutil/random_seed.c
@@ -141,5 +141,11 @@ uint32_t av_get_random_seed(void)
return seed;
if (read_random(&seed, "/dev/random") == sizeof(seed))
return seed;
+#if TEST
+ { // for testing we test get_generic_seed() seperatly so doing it here too is a waste of time
+ static int x;
+ return x++;
+ }
+#endif
return get_generic_seed();
}
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-25 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 10:21 [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: Speed up fate test Michael Niedermayer
2022-01-25 10:21 ` Michael Niedermayer [this message]
2022-01-28 12:18 ` Anton Khirnov
2022-01-30 18:23 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125102109.522-2-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git