From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: Speed up fate test Date: Tue, 25 Jan 2022 11:21:08 +0100 Message-ID: <20220125102109.522-1-michael@niedermayer.cc> (raw) This decreases the quality of the seeds during the test, it does not affect the seeds outside the test. There is a small chance that this causes test failures, if that happens the threshold needs adjusting Testing on an idle x86_64 system shows that this passes even with the test strength increased to 32768 from 256 with 0 retries So test failures are not anticipated Lowering the threshold from 3 to 2 causes failure at test strength of 32768 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavutil/random_seed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c index 70dc509d2f..509b74936c 100644 --- a/libavutil/random_seed.c +++ b/libavutil/random_seed.c @@ -95,7 +95,7 @@ static uint32_t get_generic_seed(void) last_td = t - last_t; buffer[++i & 511] += last_td % 3294638521U; if ((t - init_t) >= CLOCKS_PER_SEC>>5) - if (last_i && i - last_i > 4 || i - last_i > 64 || TEST && i - last_i > 8) + if (last_i && i - last_i > 4 || i - last_i > 64 || TEST && i - last_i > 3) break; } last_t = t; -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-01-25 10:27 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-25 10:21 Michael Niedermayer [this message] 2022-01-25 10:21 ` [FFmpeg-devel] [PATCH 2/2] libavutil/random_seed: Skip testing generic seed twice Michael Niedermayer 2022-01-28 12:18 ` [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: Speed up fate test Anton Khirnov 2022-01-30 18:23 ` Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220125102109.522-1-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git