Re: [FFmpeg-devel] [PATCH 001/289 v6] Add a new channel layout API

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2676 bytes --]

On Wed, Jan 19, 2022 at 09:09:13PM -0300, James Almer wrote:
> 
> 
> On 1/19/2022 3:07 PM, Andreas Rheinhardt wrote:
> > James Almer:
> > > From: Anton Khirnov <anton@khirnov.net>
> > > 
> > > The new API is more extensible and allows for custom layouts.
> > > More accurate information is exported, eg for decoders that do not
> > > set a channel layout, lavc will not make one up for them.
> > > 
> > > Deprecate the old API working with just uint64_t bitmasks.
> > > 
> > > Expanded and completed by Vittorio Giovara <vittorio.giovara@gmail.com>
> > > and James Almer <jamrial@gmail.com>.
> > > Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>
> > > Signed-off-by: James Almer <jamrial@gmail.com>
> > > ---
> > > Changes since last version:
> > > 
> > > *av_channel_layout_from_string() and av_channel_layout_describe() now support
> > >   a "designation@name" syntax, effectively making both functions reciprocal
> > >   when there are custom names in some or all channels.
> > >   It's the syntax suggested by Marton and is both extensible if required and
> > >   not too ulgy in human readable output if the string is printed verbatim.
> > > 
> > > *av_channel_layout_index_from_string() and
> > >   av_channel_layout_channel_from_string() also support this syntax now.
> > > 
> > > I plan to push this version soon. Any extension to the syntax supported by these
> > > helpers can be written by whoever needs it.
> > 
> > You forgot the examples and the tools; and ffplay. And do you really
> 
> Ported ffplay. Will port the rest later.
> 
> > intend for the deprecation warnings in ffmpeg_opt.c to stay?
> 
> Ok, I'll silence them.

this commit
09d90fabb4a4ca60548f6ba6b05fab9f74a0eb9e is the first bad commit
commit 09d90fabb4a4ca60548f6ba6b05fab9f74a0eb9e
Author: Anton Khirnov <anton@khirnov.net>
Date:   Tue May 7 07:20:32 2013 +0200

    cook: convert to new channel layout API
    
    Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>
    Signed-off-by: Anton Khirnov <anton@khirnov.net>
    Signed-off-by: James Almer <jamrial@gmail.com>

:040000 040000 eab7c20e8185cb7f2e78055a425eecb777cf8ff1 52f53fbe995ff4381073fd6e545dfccdcc75fb1c M	libavcodec

affects this:
libavformat/tests/seek && libavformat/tests/seek ~/tickets/1605/08.rm -frames 10

many timestamps become NOPTS

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".