From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4037B401EE for ; Thu, 20 Jan 2022 10:06:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4BCF568B2A8; Thu, 20 Jan 2022 12:06:55 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5637868B261 for ; Thu, 20 Jan 2022 12:06:49 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 6BD8DC000F for ; Thu, 20 Jan 2022 10:06:48 +0000 (UTC) Date: Thu, 20 Jan 2022 11:06:47 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220120100647.GY2829255@pb2> References: <314d1da505d135cb724f5b42a83aa1780b0633c9.1642649134.git.ffmpegagent@gmail.com> MIME-Version: 1.0 In-Reply-To: <314d1da505d135cb724f5b42a83aa1780b0633c9.1642649134.git.ffmpegagent@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v3 21/26] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8734712262613510030==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8734712262613510030== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vjMbP30k/c86sLQk" Content-Disposition: inline --vjMbP30k/c86sLQk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 20, 2022 at 03:25:29AM +0000, ffmpegagent wrote: > From: softworkz >=20 > This commit actually enables subtitle filtering in ffmpeg by > sending and receiving subtitle frames to and from a filtergraph. >=20 > The heartbeat functionality from the previous sub2video implementation > is removed and now provided by the 'subfeed' filter. > The other part of sub2video functionality is retained by > auto-insertion of the new graphicsub2video filter. >=20 > Justification for changed test refs: >=20 > - sub2video > The new results are identical excepting the last frame which > is due to the implementation changes >=20 > - sub2video_basic > The previous results had some incorrect output because multiple > frames had the same dts > The non-empty content frames are visually identical, the different > CRC is due to the different blending algorithm that is being used. >=20 > - sub2video_time_limited > The third frame in the previous ref was a repetition, which doesn't > happen anymore with the new subtitle filtering. >=20 > - sub-dvb > Running ffprobe -show_frames on the source file shows that there > are 7 subtitle frames with 0 rects in the source at the start > and 2 at the end. This translates to the 14 and 4 additional > entries in the new test results. >=20 > - filter-overlay-dvdsub-2397 > Overlay results have slightly different CRCs due to different > blending implementation >=20 > Signed-off-by: softworkz > --- > fftools/ffmpeg.c | 501 ++++----- > fftools/ffmpeg.h | 13 +- > fftools/ffmpeg_filter.c | 235 ++-- > fftools/ffmpeg_hw.c | 2 +- > fftools/ffmpeg_opt.c | 3 +- > tests/ref/fate/filter-overlay-dvdsub-2397 | 182 +-- > tests/ref/fate/sub-dvb | 162 +-- > tests/ref/fate/sub2video | 1091 +++++++++++++++++- > tests/ref/fate/sub2video_basic | 1239 +++++++++++++++++++-- > tests/ref/fate/sub2video_time_limited | 78 +- > 10 files changed, 2837 insertions(+), 669 deletions(-) segfaults Stream mapping: Stream #0:2 -> #0:0 (ass (ssa) -> subrip (srt)) Press [q] to stop, [?] for help =3D=3D4485=3D=3D Invalid read of size 8 =3D=3D4485=3D=3D at 0x3052F7: transcode (in /home/michael/ffmpeg-git/ffm= peg/ffmpeg_g) =3D=3D4485=3D=3D by 0x2DDCCB: main (in /home/michael/ffmpeg-git/ffmpeg/f= fmpeg_g) =3D=3D4485=3D=3D Address 0x10 is not stack'd, malloc'd or (recently) free'd =3D=3D4485=3D=3D=20 =3D=3D4485=3D=3D=20 =3D=3D4485=3D=3D Process terminating with default action of signal 11 (SIGS= EGV) =3D=3D4485=3D=3D Access not within mapped region at address 0x10 =3D=3D4485=3D=3D at 0x3052F7: transcode (in /home/michael/ffmpeg-git/ffm= peg/ffmpeg_g) =3D=3D4485=3D=3D by 0x2DDCCB: main (in /home/michael/ffmpeg-git/ffmpeg/f= fmpeg_g) =3D=3D4485=3D=3D If you believe this happened as a result of a stack =3D=3D4485=3D=3D overflow in your program's main thread (unlikely but =3D=3D4485=3D=3D possible), you can try to increase the size of the =3D=3D4485=3D=3D main thread stack using the --main-stacksize=3D flag. =3D=3D4485=3D=3D The main thread stack size used in this run was 8388608. will send you the sample privatly [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle --vjMbP30k/c86sLQk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYek0LwAKCRBhHseHBAsP q1b3AKCHu+ZF/26/MIxx63bNM5p3xRF0owCgkfkazXxO6vqISnMc6ln3+harEdM= =f1wi -----END PGP SIGNATURE----- --vjMbP30k/c86sLQk-- --===============8734712262613510030== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8734712262613510030==--