* [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix a memory leak problem
@ 2022-01-20 7:13 Wenbin Chen
2022-01-21 1:08 ` Xiang, Haihao
0 siblings, 1 reply; 2+ messages in thread
From: Wenbin Chen @ 2022-01-20 7:13 UTC (permalink / raw)
To: ffmpeg-devel
"qf->frame" ref to input frame but it isn't released. av_frame_unref()
is added before refering qf->frame to new frame to make sure the previous
reference is released.
Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
---
libavcodec/qsvenc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index 269386624d..fd5c460d68 100644
--- a/libavcodec/qsvenc.c
+++ b/libavcodec/qsvenc.c
@@ -1521,6 +1521,7 @@ static int submit_frame(QSVEncContext *q, const AVFrame *frame,
return ret;
}
} else {
+ av_frame_unref(qf->frame);
ret = av_frame_ref(qf->frame, frame);
if (ret < 0)
return ret;
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix a memory leak problem
2022-01-20 7:13 [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix a memory leak problem Wenbin Chen
@ 2022-01-21 1:08 ` Xiang, Haihao
0 siblings, 0 replies; 2+ messages in thread
From: Xiang, Haihao @ 2022-01-21 1:08 UTC (permalink / raw)
To: ffmpeg-devel
On Thu, 2022-01-20 at 15:13 +0800, Wenbin Chen wrote:
> "qf->frame" ref to input frame but it isn't released. av_frame_unref()
> is added before refering qf->frame to new frame to make sure the previous
> reference is released.
>
> Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> ---
> libavcodec/qsvenc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 269386624d..fd5c460d68 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -1521,6 +1521,7 @@ static int submit_frame(QSVEncContext *q, const AVFrame
> *frame,
> return ret;
> }
> } else {
> + av_frame_unref(qf->frame);
> ret = av_frame_ref(qf->frame, frame);
> if (ret < 0)
> return ret;
LGTM, will apply
-Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-21 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-20 7:13 [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix a memory leak problem Wenbin Chen
2022-01-21 1:08 ` Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git