From: Anton Khirnov <anton@khirnov.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_opencl: clear dangling pointers on map failure
Date: Wed, 19 Jan 2022 14:40:40 +0100
Message-ID: <20220119134040.774-1-anton@khirnov.net> (raw)
---
untested
---
libavutil/hwcontext_opencl.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libavutil/hwcontext_opencl.c b/libavutil/hwcontext_opencl.c
index 26a3a24593..40ee611943 100644
--- a/libavutil/hwcontext_opencl.c
+++ b/libavutil/hwcontext_opencl.c
@@ -2146,6 +2146,7 @@ fail:
clReleaseMemObject(mapping->frame.planes[p]);
}
av_free(mapping);
+ memset(dst->data, 0, sizeof(dst->data));
return err;
}
@@ -2317,6 +2318,7 @@ fail:
if (desc->planes[p])
clReleaseMemObject(desc->planes[p]);
av_freep(&desc);
+ memset(dst->data, 0, sizeof(dst->data));
return err;
}
@@ -2407,6 +2409,7 @@ fail:
0, NULL, &event);
if (cle == CL_SUCCESS)
opencl_wait_events(dst_fc, &event, 1);
+ memset(dst->data, 0, sizeof(dst->data));
return err;
}
@@ -2562,6 +2565,7 @@ fail:
0, NULL, &event);
if (cle == CL_SUCCESS)
opencl_wait_events(dst_fc, &event, 1);
+ memset(dst->data, 0, sizeof(dst->data));
return err;
}
@@ -2793,6 +2797,7 @@ fail:
clReleaseMemObject(mapping->object_buffers[i]);
}
av_free(mapping);
+ memset(dst->data, 0, sizeof(dst->data));
return err;
}
--
2.33.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-01-19 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 13:40 Anton Khirnov [this message]
2022-01-19 13:40 ` [FFmpeg-devel] [PATCH 2/3] lavu/hwcontext_vulkan: " Anton Khirnov
2022-01-19 13:40 ` [FFmpeg-devel] [PATCH 3/3] lavu/hwcontext: clarify behavior on av_hwframe_map() failure Anton Khirnov
2022-01-19 13:45 ` James Almer
2022-01-19 13:47 ` Anton Khirnov
2022-01-19 14:01 ` [FFmpeg-devel] [PATCH] " Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119134040.774-1-anton@khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git