From: "Martin Storsjö" <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [GASPP PATCH] Filter out -D parameters from the call to GCC/Clang to assemble
Date: Tue, 18 Jan 2022 15:00:12 +0200
Message-ID: <20220118130012.626437-1-martin@martin.st> (raw)
Clang warns about unused -D parameters when operating on .s
files (or if invoked with "-x assembler") while GCC doesn't.
---
As noobdy else than me essentially maintains gas-preprocessor, I'll
go ahead and push this after a couple days if nobody speaks up.
---
gas-preprocessor.pl | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 8028d81..67b130e 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -158,6 +158,10 @@ while ($index < $#preprocess_c_cmd) {
my $tempfile;
if ($as_type ne "armasm") {
@gcc_cmd = map { /\.[csS]$/ ? qw(-x assembler -) : $_ } @gcc_cmd;
+
+ # Filter out options that can cause warnings due to unused arguments,
+ # Clang warns about unused -D parameters when invoked with "-x assembler".
+ @gcc_cmd = grep ! /^-D/, @gcc_cmd;
} else {
@preprocess_c_cmd = grep ! /^-c$/, @preprocess_c_cmd;
@preprocess_c_cmd = grep ! /^-m/, @preprocess_c_cmd;
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-01-18 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 13:00 Martin Storsjö [this message]
2022-01-24 13:15 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118130012.626437-1-martin@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git