From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0B540420EE for ; Sat, 15 Jan 2022 13:47:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8FC6168B3D6; Sat, 15 Jan 2022 15:47:28 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 438DE68B344 for ; Sat, 15 Jan 2022 15:47:21 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 2C904240004 for ; Sat, 15 Jan 2022 13:47:20 +0000 (UTC) Date: Sat, 15 Jan 2022 14:47:20 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220115134720.GS2829255@pb2> References: <20220113015101.4-1-jamrial@gmail.com> <20220113020913.870-8-jamrial@gmail.com> <20220113182955.GM2829255@pb2> <93c5f897-8ed2-2168-c3d3-482b2d3c2346@gmail.com> <69adbb94-e7a6-ea0f-5406-f39f4cab995b@gmail.com> MIME-Version: 1.0 In-Reply-To: <69adbb94-e7a6-ea0f-5406-f39f4cab995b@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 277/281] ffmpeg: convert to new channel layout-API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5800736836432463420==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5800736836432463420== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZEzTQlOUPKdg91sM" Content-Disposition: inline --ZEzTQlOUPKdg91sM Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 13, 2022 at 04:44:55PM -0300, James Almer wrote: >=20 >=20 > On 1/13/2022 3:40 PM, James Almer wrote: > > On 1/13/2022 3:29 PM, Michael Niedermayer wrote: > > > On Wed, Jan 12, 2022 at 11:09:09PM -0300, James Almer wrote: > > > > Signed-off-by: James Almer > > > > --- > > > > =A0 fftools/cmdutils.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 | 42 ++++++= +++++++++--------- > > > > =A0 fftools/cmdutils.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 |=A0 8 ----- > > > > =A0 fftools/ffmpeg.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 | 47 ++= ++++++++++++++---------- > > > > =A0 fftools/ffmpeg.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 |=A0 7 = ++-- > > > > =A0 fftools/ffmpeg_filter.c=A0=A0=A0=A0=A0=A0 | 52 ++++++++++++++++= ++++++------- > > > > =A0 fftools/ffmpeg_opt.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 | 62 ++++++++++= ++++++++++++++++++++----- > > > > =A0 tests/fate/aac.mak=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 |=A0 2 +- > > > > =A0 tests/fate/lavf-container.mak |=A0 2 +- > > > > =A0 8 files changed, 155 insertions(+), 67 deletions(-) > > >=20 > > > This or a prior patch introduces crashes (it bisected to this but > > > this is my > > > 2nd testcase the first did not reproduce reliably at all) > > >=20 > > > Thread 1 "ffmpeg_g" received signal SIGSEGV, Segmentation fault. > > > 0x00005555566ed811 in av_vlog (avcl=3D0x5555577400c0, level=3D24, > > > fmt=3D0x5555568249e8 "%d frames left in the queue on closing\n", > > > vl=3D0x7fffffffda50) at libavutil/log.c:428 > >=20 > > av_vlog() is where it crashes? > >=20 > > > 428=A0=A0=A0=A0=A0=A0=A0 if (avc && avc->version >=3D (50 << 16 | 15 = << 8 | 2) && > > > (gdb) bt > > > #0=A0 0x00005555566ed811 in av_vlog (avcl=3D0x5555577400c0, level=3D2= 4, > > > fmt=3D0x5555568249e8 "%d frames left in the queue on closing\n", > > > vl=3D0x7fffffffda50) at libavutil/log.c:428 > > > #1=A0 0x00005555566ed6bd in av_log (avcl=3D0x5555577400c0, level=3D24, > > > fmt=3D0x5555568249e8 "%d frames left in the queue on closing\n") at > > > libavutil/log.c:411 > > > #2=A0 0x0000555555c320b9 in ff_af_queue_close (afq=3D0x5555576c47c8) = at > > > libavcodec/audio_frame_queue.c:39 > > > #3=A0 0x0000555555e84c06 in mp3lame_encode_close > > > (avctx=3D0x5555576bf180) at libavcodec/libmp3lame.c:86 > > > #4=A0 0x0000555555c373f7 in avcodec_close (avctx=3D0x5555576bf180) at > > > libavcodec/avcodec.c:489 > > > #5=A0 0x0000555555f7feab in avcodec_free_context > > > (pavctx=3D0x5555576a8858) at libavcodec/options.c:163 > > > #6=A0 0x000055555569cfe3 in ffmpeg_cleanup (ret=3D1) at fftools/ffmpe= g.c:608 > > > #7=A0 0x0000555555694817 in exit_program (ret=3D1) at fftools/cmdutil= s.c:131 > > > #8=A0 0x000055555569ef1f in do_audio_out (of=3D0x5555576ae2c0, > > > ost=3D0x5555576a8800, frame=3D0x5555576bf580) at fftools/ffmpeg.c:1056 > > > #9=A0 0x00005555556a117a in reap_filters (flush=3D0) at fftools/ffmpe= g.c:1546 > > > #10 0x00005555556ad8e5 in transcode_step () at fftools/ffmpeg.c:4643 > > > #11 0x00005555556ad9e7 in transcode () at fftools/ffmpeg.c:4687 > > > #12 0x00005555556ae45c in main (argc=3D12, argv=3D0x7fffffffe1c8) at > > > fftools/ffmpeg.c:4903 > > > (gdb) print avc->version > > > Cannot access memory at address 0xc1528eb7c0ea0157 > > >=20 > > > make -j32 && gdb --args ./ffmpeg_g -ss 8 -i NeroRecodeSample.mp4 > > > -bitexact -t 3 -filter_complex > > > '[0:2]scale=3D720:576[v];[v][0:5]overlay' -y file-whitesubs.avi > > >=20 > > > it appears this file is at: > > > https://samples.ffmpeg.org/MPEG-4/NeroRecodeSample-MP4/ > >=20 > > I can't reproduce this on mingw64. >=20 > Does the following fix it for you? jamrial/channel_layout4 seems not to crash anymore but the output from libswresample/tests/swresample changes substantially with that branch merged here a hunk showing that: --- /tmp/old 2022-01-15 14:38:42.370067768 +0100 +++ /tmp/new 2022-01-15 14:37:58.265740924 +0100 @@ -3,14 +3,14 @@ [e:0.037321 c:0.988153 max:0.208739] len: 968 [e:0.037581 c:0.988035 max:0.208739] len: 968 [e:0.040051 c:0.986398 max:0.208739] len: 968 -[e:0.042843 c:0.984417 max:0.215337] len: 968 -[e:0.038669 c:0.987065 max:0.208739] len: 968 +[e:0.238849 c:-nan max:0.990217] len: 968 +[e:0.236179 c:-nan max:0.990217] len: 968 [e:0.000987 c:0.999985 max:0.003293] len: 16 F: 1 [e:0.000131 c:0.999999 max:0.000438] len: 16 F: 1 [e:0.000999 c:0.999985 max:0.003333] len: 16 F: 1 [e:0.000084 c:1.000000 max:0.000280] len: 16 F: 1 -[e:0.000996 c:0.999985 max:0.003322] len: 16 F: 1 -[e:0.000027 c:1.000000 max:0.000089] len: 16 F: 1 +[e:0.181271 c:-nan max:0.297598] len: 16 F: 1 +[e:0.080519 c:-nan max:0.227637] len: 16 F: 1 =20 TEST: 3.0->7.1(wide-side), rate:16000->48000, fmt:dbl->dbl [e:0.039816 c:0.986742 max:0.283776] len: 968 =20 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein --ZEzTQlOUPKdg91sM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYeLQZAAKCRBhHseHBAsP q+ouAJ9/iOfvI4CWcEq19Li3fHxm+64B/ACdF04AObYhG2l/DlN7XLmSQn+Vf0Y= =IGEA -----END PGP SIGNATURE----- --ZEzTQlOUPKdg91sM-- --===============5800736836432463420== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5800736836432463420==--