From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1FCA241A34 for ; Fri, 14 Jan 2022 17:22:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 994FF68B417; Fri, 14 Jan 2022 19:22:18 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 084B268B229 for ; Fri, 14 Jan 2022 19:22:11 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 222AC240009 for ; Fri, 14 Jan 2022 17:22:10 +0000 (UTC) Date: Fri, 14 Jan 2022 18:22:10 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220114172210.GP2829255@pb2> References: <808f5894884f0ef73365674ce7a697e5ac46421a.1642122814.git.ffmpegagent@gmail.com> MIME-Version: 1.0 In-Reply-To: <808f5894884f0ef73365674ce7a697e5ac46421a.1642122814.git.ffmpegagent@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 06/24] avcodec/subtitles: Migrate subtitle encoders to frame-based API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2592635764976463551==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2592635764976463551== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SEB6Q5W+6ooeiGDn" Content-Disposition: inline --SEB6Q5W+6ooeiGDn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 14, 2022 at 01:13:15AM +0000, ffmpegagent wrote: > From: softworkz >=20 > and provide a compatibility shim for the legacy api >=20 > Signed-off-by: softworkz > --- > libavcodec/assenc.c | 189 ++++++++++++++++++++++++++++++------- > libavcodec/avcodec.h | 5 +- > libavcodec/dvbsubenc.c | 96 ++++++++++--------- > libavcodec/dvdsubenc.c | 102 ++++++++++++-------- > libavcodec/encode.c | 57 ++++++++++- > libavcodec/movtextenc.c | 114 ++++++++++++++++------ > libavcodec/srtenc.c | 108 ++++++++++++++------- > libavcodec/tests/avcodec.c | 2 - > libavcodec/ttmlenc.c | 101 +++++++++++++++----- > libavcodec/webvttenc.c | 86 ++++++++++++----- > libavcodec/xsubenc.c | 88 ++++++++++------- > 11 files changed, 685 insertions(+), 263 deletions(-) is this supposed to pass make fate without the later patches ? it seems not here: --- ./tests/ref/fate/sub-webvtt2 2022-01-13 23:24:22.195685643 +0100 +++ tests/data/fate/sub-webvtt2 2022-01-14 18:04:09.528302263 +0100 @@ -11,15 +11,3 @@ =20 [Events] Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect,= Text -Dialogue: 0,0:00:00.00,0:00:20.00,Default,,0,0,0,,Hi, my name is Fred -Dialogue: 0,0:00:02.50,0:00:22.50,Default,,0,0,0,,Hi, I=E2=80=99m Bill -Dialogue: 0,0:00:05.00,0:00:25.00,Default,,0,0,0,,Would you like to get a = coffee? -Dialogue: 0,0:00:07.50,0:00:27.50,Default,,0,0,0,,Sure! I=E2=80=99ve only = had one today. -Dialogue: 0,0:00:10.00,0:00:30.00,Default,,0,0,0,,This is my fourth! -Dialogue: 0,0:00:12.50,0:00:32.50,Default,,0,0,0,,OK, let=E2=80=99s go. -Dialogue: 0,0:00:38.00,0:00:43.00,Default,,0,0,0,,I want to =E6=84=9B=E3= =81=82=E3=81=84 love you\NThat's not proper English! -Dialogue: 0,0:00:43.00,0:00:46.00,Default,,0,0,0,,{\i1}=E3=82=AD=E3=83=84= =E3=83=8D{\i0}=E3=81=98=E3=82=83=E3=81=AA=E3=81=84=E3=80=80=E3=82=AD=E3=83= =84=E3=83=8D=E3=81=98=E3=82=83=E3=81=AA=E3=81=84\N=E4=B9=99=E5=A5=B3=E3=81= =8A=E3=81=A8=E3=82=81=E3=81=AF -Dialogue: 0,0:00:50.00,0:00:55.00,Default,,0,0,0,,Some time ago in a rathe= r distant place.... -Dialogue: 0,0:00:55.00,0:01:00.00,Default,,0,0,0,,Descending: 123456\NAsce= nding: 123456 -Dialogue: 0,0:01:00.00,0:01:05.00,Default,,0,0,0,,>> Never gonna give you = up Never gonna let you down\NNever\hgonna\hrun\haround & desert\hyou -Dialogue: 0,0:55:00.00,1:00:00.00,Default,,0,0,0,,Transcrit par C=C3=A9les= tes=E2=84=A2 Test sub-webvtt2 failed. Look at tests/data/fate/sub-webvtt2.err for detail= s. tests/Makefile:256: recipe for target 'fate-sub-webvtt2' failed make: *** [fate-sub-webvtt2] Error 139 if you cannot reproduce then say so and ill get e better backtrace Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in () #1 0x0000555555c7d2cf in avcodec_encode_subtitle () #2 0x0000555555744daa in transcode_subtitles () #3 0x000055555574b9eb in process_input_packet () #4 0x000055555574d64d in transcode () #5 0x0000555555725ebc in main () [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --SEB6Q5W+6ooeiGDn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYeGxPgAKCRBhHseHBAsP q7SPAJ4w8WmFjawWEVnCp9To9yxwx1h5mQCfdwBseEGoSquJr8hgpNV+Jo2Th94= =6/i9 -----END PGP SIGNATURE----- --SEB6Q5W+6ooeiGDn-- --===============2592635764976463551== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2592635764976463551==--