From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7DE9E41A28 for ; Fri, 14 Jan 2022 16:53:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3964C68B470; Fri, 14 Jan 2022 18:53:01 +0200 (EET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7B62268B347 for ; Fri, 14 Jan 2022 18:52:54 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 6E002100008 for ; Fri, 14 Jan 2022 16:52:53 +0000 (UTC) Date: Fri, 14 Jan 2022 17:52:52 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220114165252.GO2829255@pb2> References: <00643582cfc13d22e7967fef50e9b0078ee99657.1642122814.git.ffmpegagent@gmail.com> MIME-Version: 1.0 In-Reply-To: <00643582cfc13d22e7967fef50e9b0078ee99657.1642122814.git.ffmpegagent@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 21/24] fftools/ffmpeg: Introduce subtitle filtering new frame-based subtitle encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7695577442310445642==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7695577442310445642== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tUvAIh/8EUC9tcb4" Content-Disposition: inline --tUvAIh/8EUC9tcb4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 14, 2022 at 01:13:30AM +0000, ffmpegagent wrote: > From: softworkz >=20 > This commit actually enables subtitle filtering in ffmpeg by > sending and receiving subtitle frames to and from a filtergraph. >=20 > The heartbeat functionality from the previous sub2video implementation > is removed and now provided by the 'subfeed' filter. > The other part of sub2video functionality is retained by > auto-insertion of the new graphicsub2video filter. >=20 > Justification for changed test refs: >=20 > - sub2video > The new results are identical excepting the last frame which > is due to the implementation changes >=20 > - sub2video_basic > The previous results had some incorrect output because multiple > frames had the same dts > The non-empty content frames are visually identical, the different > CRC is due to the different blending algorithm that is being used. >=20 > - sub2video_time_limited > The third frame in the previous ref was a repetition, which doesn't > happen anymore with the new subtitle filtering. >=20 > - sub-dvb > Running ffprobe -show_frames on the source file shows that there > are 7 subtitle frames with 0 rects in the source at the start > and 2 at the end. This translates to the 14 and 4 additional > entries in the new test results. >=20 > - filter-overlay-dvdsub-2397 > Overlay results have slightly different CRCs due to different > blending implementation >=20 > Signed-off-by: softworkz > --- > fftools/ffmpeg.c | 493 ++++---- > fftools/ffmpeg.h | 13 +- > fftools/ffmpeg_filter.c | 235 ++-- > fftools/ffmpeg_hw.c | 2 +- > fftools/ffmpeg_opt.c | 3 +- > tests/ref/fate/filter-overlay-dvdsub-2397 | 182 +-- > tests/ref/fate/sub-dvb | 162 +-- > tests/ref/fate/sub2video | 1091 +++++++++++++++++- > tests/ref/fate/sub2video_basic | 1239 +++++++++++++++++++-- > tests/ref/fate/sub2video_time_limited | 78 +- > 10 files changed, 2829 insertions(+), 669 deletions(-) =2E/ffmpeg -i ~/tickets/153/bbc_small.ts -filter_complex '[0:v][0:s]overlay= ' -qscale 2 -t 3 f.avi Press [q] to stop, [?] for help Auto-inserting subfeed filter Auto-inserting graphicsub2video filter Assertion c > 0 failed at libavutil/mathematics.c:60 Aborted (core dumped) [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein --tUvAIh/8EUC9tcb4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYeGqYAAKCRBhHseHBAsP q6tkAJ4kTyNTHAw5T2ZsBt8R5KU5fsB3/gCcCvxTFZrAyArcNWS6ObrJFDIwgs8= =fryN -----END PGP SIGNATURE----- --tUvAIh/8EUC9tcb4-- --===============7695577442310445642== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7695577442310445642==--