From: Anton Khirnov <anton@khirnov.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 04/35] lavu/fifo: add new functions for determinining reading/writing size Date: Tue, 11 Jan 2022 21:45:39 +0100 Message-ID: <20220111204610.14262-4-anton@khirnov.net> (raw) In-Reply-To: <20220111204610.14262-1-anton@khirnov.net> Consistently use size_t for sizes. The new names should also be more clear - e.g. current av_fifo_size() could be misinterpreted as meaning the allocated size. --- doc/APIchanges | 2 +- libavutil/fifo.c | 16 +++++++++++++--- libavutil/fifo.h | 10 ++++++++++ 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 5646cf2278..9400c5147a 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -18,7 +18,7 @@ API changes, most recent first: Add av_fifo_alloc2(), which allows setting a FIFO element size. Operations on FIFOs created with this function on these elements rather than bytes. - Add av_fifo_elem_size(). + Add av_fifo_elem_size(), av_fifo_can_read(), av_fifo_can_write(). 2022-01-xx - xxxxxxxxxx - lavu fifo.h Access to all AVFifoBuffer members is deprecated. The struct will diff --git a/libavutil/fifo.c b/libavutil/fifo.c index fc7c93470f..8cde2c20e1 100644 --- a/libavutil/fifo.c +++ b/libavutil/fifo.c @@ -126,7 +126,7 @@ size_t av_fifo_elem_size(const AVFifoBuffer *f) return fb->elem_size; } -int av_fifo_size(const AVFifoBuffer *f) +size_t av_fifo_can_read(const AVFifoBuffer *f) { const FifoBuffer *fb = (const FifoBuffer*)f; if (fb->offset_w <= fb->offset_r && !fb->is_empty) @@ -134,10 +134,20 @@ int av_fifo_size(const AVFifoBuffer *f) return fb->offset_w - fb->offset_r; } -int av_fifo_space(const AVFifoBuffer *f) +size_t av_fifo_can_write(const AVFifoBuffer *f) { const FifoBuffer *fb = (const FifoBuffer*)f; - return fb->nb_elems - av_fifo_size(f); + return fb->nb_elems - av_fifo_can_read(f); +} + +int av_fifo_size(const AVFifoBuffer *f) +{ + return av_fifo_can_read(f); +} + +int av_fifo_space(const AVFifoBuffer *f) +{ + return av_fifo_can_write(f); } int av_fifo_realloc2(AVFifoBuffer *f, unsigned int new_size) diff --git a/libavutil/fifo.h b/libavutil/fifo.h index 22362c0239..9e78082b3b 100644 --- a/libavutil/fifo.h +++ b/libavutil/fifo.h @@ -119,6 +119,16 @@ int av_fifo_size(const AVFifoBuffer *f); */ int av_fifo_space(const AVFifoBuffer *f); +/** + * @return number of elements available for reading from the given FIFO. + */ +size_t av_fifo_can_read(const AVFifoBuffer *f); + +/** + * @return number of elements that can be written into the given FIFO. + */ +size_t av_fifo_can_write(const AVFifoBuffer *f); + /** * Feed data at specific position from an AVFifoBuffer to a user-supplied callback. * Similar as av_fifo_gereric_read but without discarding data. -- 2.33.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-11 20:47 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-11 20:45 [FFmpeg-devel] [PATCH 01/35] lavu/fifo: disallow overly large fifo sizes Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 02/35] lavu/fifo: make the contents of AVFifoBuffer private on next major bump Anton Khirnov 2022-01-13 14:22 ` Andreas Rheinhardt 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 03/35] lavu/fifo: introduce the notion of element size Anton Khirnov 2022-01-13 16:50 ` Andreas Rheinhardt 2022-01-13 16:59 ` James Almer 2022-01-11 20:45 ` Anton Khirnov [this message] 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 05/35] lavu/fifo: add a new FIFO grow function Anton Khirnov 2022-01-13 17:04 ` James Almer 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 06/35] lavu/fifo: add a new function for draining the FIFO Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 07/35] lavu/fifo: add new FIFO writing functions Anton Khirnov 2022-01-13 17:31 ` Andreas Rheinhardt 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 08/35] lavu/fifo: add new FIFO read/peek functions Anton Khirnov 2022-01-13 17:41 ` Andreas Rheinhardt 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 09/35] lavu/fifo: add a flag for automatically growing the FIFO as needed Anton Khirnov 2022-01-13 17:53 ` Andreas Rheinhardt 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 10/35] lavu/fifo: deprecate old API Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 11/35] lavu/tests/fifo: switch to the new API Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 12/35] lavc/avcodec: switch to new FIFO API Anton Khirnov 2022-01-13 18:21 ` Andreas Rheinhardt 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 13/35] lavc/amfenc: " Anton Khirnov 2022-01-12 14:46 ` Michael Niedermayer 2022-01-12 19:29 ` Anton Khirnov 2022-01-13 14:14 ` Michael Niedermayer 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 14/35] lavc/cuviddec: do not reallocate the fifo unnecessarily Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 15/35] lavc/cuviddec: convert to the new FIFO API Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 16/35] lavc/libvorbisenc: switch to " Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 17/35] lavc/libvpxenc: switch to the " Anton Khirnov 2022-01-12 18:15 ` James Zern 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 18/35] lavc/libvpxenc: remove unneeded context variable Anton Khirnov 2022-01-12 18:15 ` James Zern 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 19/35] lavc/nvenc: switch to the new FIFO API Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 20/35] lavc/qsvdec: " Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 21/35] lavc/qsvenc: switch to " Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 22/35] lavf/dvenc: return an error on audio/video desync Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 23/35] lavf/dvenc: switch to new FIFO API Anton Khirnov 2022-01-11 20:45 ` [FFmpeg-devel] [PATCH 24/35] lavf/mpegenc: " Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 25/35] lavf/swfenc: " Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 26/35] lavf/udp: " Anton Khirnov 2022-01-13 18:45 ` Andreas Rheinhardt 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 27/35] lavf/async: " Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 28/35] lavd/jack: switch to the " Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 29/35] lavu/audio_fifo: drop an unnecessary include Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 30/35] lavu/audio_fifo: switch to new FIFO API Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 31/35] lavu/threadmessage: " Anton Khirnov 2022-01-13 19:03 ` Andreas Rheinhardt 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 32/35] lavfi/qsvvpp: " Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 33/35] lavfi/vf_deshake_opencl: " Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 34/35] ffplay: " Anton Khirnov 2022-01-11 20:46 ` [FFmpeg-devel] [PATCH 35/35] ffmpeg: " Anton Khirnov 2022-01-13 13:59 ` [FFmpeg-devel] [PATCH 01/35] lavu/fifo: disallow overly large fifo sizes Andreas Rheinhardt 2022-01-13 14:27 ` Anton Khirnov 2022-01-13 14:38 ` Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220111204610.14262-4-anton@khirnov.net \ --to=anton@khirnov.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git