Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andriy Gelman <andriy.gelman@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Kieran Kunhya <kieran618@googlemail.com>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution
Date: Sun, 9 Jan 2022 12:15:15 -0500
Message-ID: <20220109171515.5bobkxpthjxzirun@jackie> (raw)
In-Reply-To: <6abb9c0-404b-dd21-b33-a82ed16b2b73@martin.st>

On Fri, 07. Jan 01:30, Martin Storsjö wrote:
> On Wed, 5 Jan 2022, Martin Storsjö wrote:
> 
> > While this function on its own passes all of fate-hevc, there's
> > indications that the function might need to handle widths that
> > aren't a multiple of 8 (noted in commit
> > f63f9be37c799ddc835af358034630d31fb7db02, which later was
> > reverted).
> > ---
> > libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)

> 
> As fate-hevc still is broken on aarch64, is anyone opposed to pushing these
> reverts until the things is sorted out?
> 
> I'm all for fixing things, but we don't need to leave things broken in git
> master while doing so.
> 

I can set up a patchwork CI runner on the FFmpeg M1 machine to catch these in
the future.
Kieran, can you set up a user for me?

Thanks,
-- 
Andriy
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2022-01-09 17:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05  8:31 [FFmpeg-devel] [PATCH 1/4] Revert "lavc/aarch64: add hevc sao band 8x8 tiling" Martin Storsjö
2022-01-05  8:31 ` [FFmpeg-devel] [PATCH 2/4] Revert "lavc/aarch64: add hevc sao edge 8x8" Martin Storsjö
2022-01-05  8:31 ` [FFmpeg-devel] [PATCH 3/4] Revert "lavc/aarch64: add hevc sao edge 16x16" Martin Storsjö
2022-01-05  8:31 ` [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution Martin Storsjö
2022-01-05 12:08   ` James Almer
2022-01-05 12:15     ` Martin Storsjö
2022-01-06 23:30   ` Martin Storsjö
2022-01-07 21:01     ` Martin Storsjö
2022-01-09 17:15     ` Andriy Gelman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220109171515.5bobkxpthjxzirun@jackie \
    --to=andriy.gelman@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=kieran618@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git