From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7E7DA42846 for ; Sun, 9 Jan 2022 01:38:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C8C0568A86C; Sun, 9 Jan 2022 03:38:11 +0200 (EET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7725B689F94 for ; Sun, 9 Jan 2022 03:38:05 +0200 (EET) Received: by mail-pj1-f42.google.com with SMTP id ie23-20020a17090b401700b001b38a5318easo2975530pjb.2 for ; Sat, 08 Jan 2022 17:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=KrXhFWSYiv/dn6bUueeJcU3eGZuwWtZ1y/Ca2ZsPCuM=; b=exCTZbf/Yj3fWg2IpQDIWo8O6Zzg/4tgZpB/9zRmzSSs/rlfRw1mn6yQvNalPf3f3R 3S9MP0YpCyqubcJcvP+X34ZorriL85Z+M8lDNf/aUxS0rrwE6c79GFFL/IgayAm8PBJK sdg9C5UqnMImXO97g3BCxv7uHDLtzspE1VDIQe2yZRrjpeqXDlcCPmeIM5inUnISP40K sIYjUbKelgKohh5FL71I8OjNhX+badZoGQjTE1IjHNuiEWkAqHdaSkamxUYqQHVDfRII ar0wFBC/Zq6pjjxjf026LeJf6BCRh/AQcFfGigexX5kZFC86swLeULO0Mrs5DxQ+maCW 7FZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=KrXhFWSYiv/dn6bUueeJcU3eGZuwWtZ1y/Ca2ZsPCuM=; b=X6T5ZD9m5djQuCWm3p5lOuqjCbh67TFjDcuH+TBhuHMFuYu9vjc2LCcO4DTVaoZPsR 0ZmzgNsoXYDCAYBITyfdiiZFGXkiaLi1WgaN4GsnAFh/EWIueV5D+qP+tTMpxfd/zBM+ h8vTJMiySO1VLfmqHUJcWBQnH6Ov7+gJxvrbuxJrON55df2zp1d/x96NgDc8MG5aY8KJ coYbUzIlemAHWUkGKsLTNqqLxCs4W8beQeuMwS0Jaa18FF2td4DIvoFLfHqe8RXunfWB EN866i1qhxkSHZo1UacX96QPBjCfzcPCB3aBSZrR/Qqs2Lk3jQvzTcIkDHVGw6C0NU3+ b0RQ== X-Gm-Message-State: AOAM530Dcm1wemXhaWADL7mLMuuBpWvQgG1sgkg5htqsHKlhalHxr6b6 q51pdAzw4nfOSazpVJgMPMPYIoWk7l0= X-Google-Smtp-Source: ABdhPJzygYrZPctSy7eEojUJOeF0ek/syv//z+l8uaWBtnDZBwCiJbfP7sWy5DyJWUsBq76tpbx66w== X-Received: by 2002:a17:90a:a90:: with SMTP id 16mr22964750pjw.125.1641692282992; Sat, 08 Jan 2022 17:38:02 -0800 (PST) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id m9sm2917468pjk.51.2022.01.08.17.38.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Jan 2022 17:38:02 -0800 (PST) Date: Sun, 9 Jan 2022 09:37:59 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20220109013759.GA7713@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/rawvideodec: Disable option accidentally added for v210(x) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Jan 08, 2022 at 09:08:58PM +0100, Andreas Rheinhardt wrote: > 41f213c3bf629d549400e935e7f123e6cfa959ab accidentally added > an unused pixel_format option to the v210(x) demuxers. > Remove it before it really becomes part of the API. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/rawvideodec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/rawvideodec.c b/libavformat/rawvideodec.c > index 68547fc50f..3f92211af1 100644 > --- a/libavformat/rawvideodec.c > +++ b/libavformat/rawvideodec.c > @@ -126,8 +126,9 @@ static int rawvideo_read_packet(AVFormatContext *s, AVPacket *pkt) > #define OFFSET(x) offsetof(RawVideoDemuxerContext, x) > #define DEC AV_OPT_FLAG_DECODING_PARAM > static const AVOption rawvideo_options[] = { > - { "video_size", "set frame size", OFFSET(width), AV_OPT_TYPE_IMAGE_SIZE, {.str = NULL}, 0, 0, DEC }, > + /* pixel_format is not used by the v210 demuxers. */ > { "pixel_format", "set pixel format", OFFSET(pixel_format), AV_OPT_TYPE_STRING, {.str = "yuv420p"}, 0, 0, DEC }, > + { "video_size", "set frame size", OFFSET(width), AV_OPT_TYPE_IMAGE_SIZE, {.str = NULL}, 0, 0, DEC }, > { "framerate", "set frame rate", OFFSET(framerate), AV_OPT_TYPE_VIDEO_RATE, {.str = "25"}, 0, INT_MAX, DEC }, > { NULL }, > }; > @@ -175,7 +176,7 @@ const AVInputFormat ff_bitpacked_demuxer = { > static const AVClass v210_demuxer_class = { > .class_name = "v210(x) demuxer", > .item_name = av_default_item_name, > - .option = rawvideo_options, > + .option = rawvideo_options + 1, > .version = LIBAVUTIL_VERSION_INT, > }; LGTM. > > -- > 2.32.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".