From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/hevcdec: Combine multiple allocations
Date: Thu, 6 Jan 2022 13:00:37 +0100
Message-ID: <20220106120037.GD2829255@pb2> (raw)
In-Reply-To: <AM7PR03MB66607646AC3BB14539F62FF48F4C9@AM7PR03MB6660.eurprd03.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 1170 bytes --]
On Thu, Jan 06, 2022 at 10:56:37AM +0100, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > On Wed, Jan 05, 2022 at 10:18:11PM +0100, Andreas Rheinhardt wrote:
> >> Reduces the number of allocs and frees.
> >>
> >> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> >> ---
> >> libavcodec/hevcdec.c | 11 ++++-------
> >> 1 file changed, 4 insertions(+), 7 deletions(-)
> >
> > something in the patches today causes a segfault in a hevc stream with slice threading
> > iam trying to bisect it but it but it does not replicate at all reliably ATM
> > so i dont even know if its from a patch today
> > just wanted to report what i know ATM ...
> >
> > thx
>
> On what arch did you test this? Josh's recent patchset [1] caused
> segfaults on aarch64, see also [2]. I actually tested with slice
> threading (which this data is all about). But I will nevertheless look
> at your sample.
x86-64
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-01-06 12:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 21:18 Andreas Rheinhardt
2022-01-05 21:19 ` [FFmpeg-devel] [PATCH 2/4] avcodec/hevcdec: Remove redundant frees Andreas Rheinhardt
2022-01-05 21:19 ` [FFmpeg-devel] [PATCH 3/4] avcodec/hevcdec: Combine related data into structure Andreas Rheinhardt
2022-01-05 21:19 ` [FFmpeg-devel] [PATCH 4/4] avcodec/hevcdec: Avoid redundant entry_point_offsets array Andreas Rheinhardt
2022-01-06 9:47 ` Michael Niedermayer
2022-01-06 9:40 ` [FFmpeg-devel] [PATCH 1/4] avcodec/hevcdec: Combine multiple allocations Michael Niedermayer
2022-01-06 9:56 ` Andreas Rheinhardt
2022-01-06 12:00 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106120037.GD2829255@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git