From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF4D44252F for ; Wed, 5 Jan 2022 01:21:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E41A768A82A; Wed, 5 Jan 2022 03:21:28 +0200 (EET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B084B68980E for ; Wed, 5 Jan 2022 03:21:22 +0200 (EET) Received: by mail-pj1-f43.google.com with SMTP id y16-20020a17090a6c9000b001b13ffaa625so1682844pjj.2 for ; Tue, 04 Jan 2022 17:21:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=YLqPLp15N8FbH8CMOZWEAvQRB8q2jg5ReABIcaT9XiU=; b=o71kyGtuavKruR46n+hRhXct+eqYeNbfC7jJ/hhkXfxbewMgdIYFs92ans6tU9lCua WD9ZD5jaYtBnXT+m2lUdc9/il8iI85/52Y7bjWu3jA0V2DWspAN35HLb/fsGutE3WwQ1 6MWwFo+cKjKDz6/bHTa5YSEKn+KYzejdiCKmDhSq4c7jUsSg35X+CL0mNyd7uLI3yJC/ nq4yf48lDzl48ZRdEqOckvx5Tq5PN5SUl+PgYkeoJjivbocB5aXWBN95Vj+j6iruX5Lx N3gk9NZVq202K0sRr25GJQI1Z/QIQ9rTMSkO7e9g3pZUJc1xHD7YsG4FdWWvDDp2w0Hk fBug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=YLqPLp15N8FbH8CMOZWEAvQRB8q2jg5ReABIcaT9XiU=; b=rshFN/glLVRNH3ZFp5bDE9ycVnBbehOp1okIlsOsH56XN6yQbOY+qaSYcZKp98qW9I F4Y2Kza5TbzqvbfSJDoxpl/j3uBdvStWqitBhDNXdA/RKvmHqSTdLRVbg8VEbHaSWwOg UO4mjo4ob47vth7kqGmE9BtgDXneKrEA1jQ1wkDHOjc1p0pFO7/Yat0RhsmMIRLr6bVq t2DY6iUlmi4/WDoBHMq+2RrxtCsXXBUT7yK4Xb/pfRw0VQmvcrgKLMGemN0g7NillTcL HJRrvZTFEx9n0aPo1H1yUxkUuZWUTuUAg0Xe1AEkSrGq0xHa6j6MyH/y7BYXiobAVzme Dw4w== X-Gm-Message-State: AOAM5338jnPLzJaIjiy+SLM+JYrtdRUC9SqMuIM7O3BWnsOo2YMVfU6R czXnvC5kLCIS2wnRntXUEkMDtPjjmE4= X-Google-Smtp-Source: ABdhPJxRKmPTBW85bzR00owRJXojgKAZ3xdVJyMmdpg20o9xOgYkqHydHsGBAX+4DGYMnO6Ow8ROkA== X-Received: by 2002:a17:90b:1b11:: with SMTP id nu17mr1249790pjb.167.1641345680919; Tue, 04 Jan 2022 17:21:20 -0800 (PST) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id b11sm45827689pfv.39.2022.01.04.17.21.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jan 2022 17:21:20 -0800 (PST) Date: Wed, 5 Jan 2022 09:21:17 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20220105012117.GA14919@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <1641289393-4372-1-git-send-email-lance.lmwang@gmail.com> <8448DF04-D4A1-40AB-A4CF-2F4E65301300@gmail.com> <20220105011528.GA14829@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jan 04, 2022 at 10:17:17PM -0300, James Almer wrote: > > > On 1/4/2022 10:15 PM, lance.lmwang@gmail.com wrote: > > On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote: > > > > > > > On Jan 4, 2022, at 3:43 AM, lance.lmwang@gmail.com wrote: > > > > > > > > From: Limin Wang > > > > > > > > Please reproduced with the following minimal configure command: > > > > ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox > > > > > > > > You'll get below error: > > > > > > > > Undefined symbols for architecture x86_64: > > > > "_ff_videotoolbox_vpcc_extradata_create", referenced from: > > > > _videotoolbox_start in videotoolbox.o > > > > ld: symbol(s) not found for architecture x86_64 > > > > clang: error: linker command failed with exit code 1 (use -v to see invocation) > > > > > > > > Reported-by: Cameron Gutman > > > > Signed-off-by: Limin Wang > > > > --- > > > > > > Thanks, this fixes the build break for me. Please merge it into 5.0 if possible. > > > > > > Tested-by: Cameron Gutman > > > > thank for the testing, will apply and try to merge to 5.0. > > A cherry-pick should work without conflicts for this change. Yes, I'm glad to use cherry-pick for merge always. > > > > > > > > > > libavcodec/videotoolbox.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > > > > index 69beb38..51d4eac 100644 > > > > --- a/libavcodec/videotoolbox.c > > > > +++ b/libavcodec/videotoolbox.c > > > > @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec > > > > if (data) > > > > CFDictionarySetValue(avc_info, CFSTR("hvcC"), data); > > > > break; > > > > +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL > > > > case kCMVideoCodecType_VP9 : > > > > data = ff_videotoolbox_vpcc_extradata_create(avctx); > > > > if (data) > > > > CFDictionarySetValue(avc_info, CFSTR("vpcC"), data); > > > > break; > > > > +#endif > > > > default: > > > > break; > > > > } > > > > -- > > > > 1.8.3.1 > > > > > > > > _______________________________________________ > > > > ffmpeg-devel mailing list > > > > ffmpeg-devel@ffmpeg.org > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > > > To unsubscribe, visit link above, or email > > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".