From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 46BFC42527 for ; Wed, 5 Jan 2022 01:15:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 724CE68A7C0; Wed, 5 Jan 2022 03:15:39 +0200 (EET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 92B33689B39 for ; Wed, 5 Jan 2022 03:15:33 +0200 (EET) Received: by mail-pj1-f43.google.com with SMTP id b1-20020a17090a990100b001b14bd47532so4890808pjp.0 for ; Tue, 04 Jan 2022 17:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=WzbBAzNaA6WdbMRa9bLfAALbDMcRrfo++RnBvwrn6V8=; b=el6r48kGVZDbSCuWHzgI8xYOWUEawSa1DvB0DrbY0j8lbvCz+t6k/fm7Y4gG0er3Fj 6Kx9XNRQZ5/O7OGdAtIPfhmKK9FGT/phzOsnbs3zcedTyt84CrkFuy+QT1E45xMVYUpq t8SgLNUCuWOsE4u15bYuvQqp4toF6FPpv6AsjQBWpUTRKMkbZH/99zXmqbyI9NLLbD6h SJUnmp2QRRGqLmMs+fdKuh2Fh1yFh53H09zhknB3IGFQg9wlT0kxfmX0HTi3k/o66Q3U C6voJZtoB5e5cDT93jMcxNUnqKG+4N0kSYBJuvxLHnovU7LS0vbDLmKVykI7Gk9OBBCB Upew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=WzbBAzNaA6WdbMRa9bLfAALbDMcRrfo++RnBvwrn6V8=; b=1qhDhV+rC3aNddGGcW4t33s19WAYqhVDmMscrtTf/yD6faGD3b4PzoCw3TttTLbeUt H+mfSDw+tFnmbPtYfht6yaRQaS9wixJhd7hc7NUgl5Ctjawr1efs2vD45GLw2Q1zS6Vp IZSzsQIbbi770KLngRgRLBBa8wR9dh46A6ga9vptOMYKMphRH9jEUQO79031lnrT3zY6 RmJVWpy2/rPxje7tw/sTVe5KAixbk9Xfu6GzhjynXe0ZgpOS4yzQOc6b8j5Zs+B5EI2b m7aiwdwRkW4RZ7F7UQh6kvHxE859dFzjl7mDvrttBbuG+e3ktcN+qMvQtSbOAqlsFjC8 CNGw== X-Gm-Message-State: AOAM530sxJ3yuvA8sPOkj/9xm/nBiEs/6wcZBD+rSwxFjg8VCB4g5xcT jYuE/HOrh4bmHuSXJY9hs41RtxHAZ60= X-Google-Smtp-Source: ABdhPJy+n3XXs86WP+L0Vjj6wXO1LKZCO8Psbennsp4Z6M3AdjndB54gb42fU4qHt/4WHbSmT6o26g== X-Received: by 2002:a17:90a:9f01:: with SMTP id n1mr1252388pjp.201.1641345331789; Tue, 04 Jan 2022 17:15:31 -0800 (PST) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id d14sm41847271pfl.132.2022.01.04.17.15.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jan 2022 17:15:31 -0800 (PST) Date: Wed, 5 Jan 2022 09:15:28 +0800 From: lance.lmwang@gmail.com To: FFmpeg development discussions and patches Message-ID: <20220105011528.GA14829@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches References: <1641289393-4372-1-git-send-email-lance.lmwang@gmail.com> <8448DF04-D4A1-40AB-A4CF-2F4E65301300@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8448DF04-D4A1-40AB-A4CF-2F4E65301300@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote: > > > On Jan 4, 2022, at 3:43 AM, lance.lmwang@gmail.com wrote: > > > > From: Limin Wang > > > > Please reproduced with the following minimal configure command: > > ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox > > > > You'll get below error: > > > > Undefined symbols for architecture x86_64: > > "_ff_videotoolbox_vpcc_extradata_create", referenced from: > > _videotoolbox_start in videotoolbox.o > > ld: symbol(s) not found for architecture x86_64 > > clang: error: linker command failed with exit code 1 (use -v to see invocation) > > > > Reported-by: Cameron Gutman > > Signed-off-by: Limin Wang > > --- > > Thanks, this fixes the build break for me. Please merge it into 5.0 if possible. > > Tested-by: Cameron Gutman thank for the testing, will apply and try to merge to 5.0. > > > libavcodec/videotoolbox.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > > index 69beb38..51d4eac 100644 > > --- a/libavcodec/videotoolbox.c > > +++ b/libavcodec/videotoolbox.c > > @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec > > if (data) > > CFDictionarySetValue(avc_info, CFSTR("hvcC"), data); > > break; > > +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL > > case kCMVideoCodecType_VP9 : > > data = ff_videotoolbox_vpcc_extradata_create(avctx); > > if (data) > > CFDictionarySetValue(avc_info, CFSTR("vpcC"), data); > > break; > > +#endif > > default: > > break; > > } > > -- > > 1.8.3.1 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".