From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 69CBD4250B for ; Tue, 4 Jan 2022 22:48:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC9AC68A1A7; Wed, 5 Jan 2022 00:48:34 +0200 (EET) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9CB01689CA7 for ; Wed, 5 Jan 2022 00:48:28 +0200 (EET) Received: by mail-qk1-f181.google.com with SMTP id w27so30319947qkj.7 for ; Tue, 04 Jan 2022 14:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ICzUT6eFLNOgdmv6qBvQTtTuDX1YIMKDGWtyJXhhJp0=; b=Te7lC5HRODz1I3UGCU8wXpbLbHC/CReUWHNjnViRFpQc/Gxah+jXt8SQ0UYg6VT4Uy 3eB0t1W++FDcIjyzNolhaNI5hVQB9QK3mxIO54+1YxlUWj/YWpYzzsYTk82w/WKj8Mmr HBQ00FyntmInr1sIF6lkAwSLChKkU9Ljr9EoBPPKHj0du83iLShGe6tlw3tC+HOFmHN2 FvKM+0n6YenUCZMg2Zj54Wt3zMyi6waNhKdz9a4eUuUJtQ1Vb90Vmx/ofAt2unoq9aUL KI2VMVklH9SCfI23J37T96NXaqmWyQo2YlRYrt/p7kzqjuh9/KgmSFLmJFXiE50cX2BC R/og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ICzUT6eFLNOgdmv6qBvQTtTuDX1YIMKDGWtyJXhhJp0=; b=paK48GtAdFQk2aaMP4FKpi+OZVoJyYPnPTkbVvrPlN2ODWhMy8xcfGtpy10CfJMgYO QM+RyZXTyGcqHQ5JGrYu98TZqkaEg5NVWkgq6XnF/3dN/Vp5k51JcgqbiJuCvk6+1IBo G8GdKgrJt9OJB2aK7EVLP4Zl3O99hvT6dSLVoqA9E7buNfD+KmWTrbsL5qFezeAu8i3C x4DNoVgoQBbq6Ml/uaPQmfNpXyORjtLaGjpZ/WOwR+0BqI6r0Vv8w/4Qv1xpitgmCHfA o4DCImXNtQdDrYmp44eekFQsirnsbH6prwMA+vj7+S8KGpn7UM7aHmd9vnwOSUmaUWzm i0XQ== X-Gm-Message-State: AOAM532N4gP4nP5IB+6+q6XSOJex6YYOTIKC1KJX+bn9d1xlqAuTqzA+ iPZS2lM0qA2Fp0YuVKt85Z4= X-Google-Smtp-Source: ABdhPJxFeaP7etsjmKfx/3G4JrckLBkV0X+nx2pxFK1auOHIuS2I997sOgikxRpa0yhRCZr/XTOmtQ== X-Received: by 2002:a05:620a:1515:: with SMTP id i21mr34338756qkk.665.1641336494955; Tue, 04 Jan 2022 14:48:14 -0800 (PST) Received: from jackie (pool-108-20-185-127.bstnma.fios.verizon.net. [108.20.185.127]) by smtp.gmail.com with ESMTPSA id v12sm34070109qtx.80.2022.01.04.14.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 14:48:14 -0800 (PST) Date: Tue, 4 Jan 2022 17:48:13 -0500 From: Andriy Gelman To: Ming Qian Message-ID: <20220104224813.cfsz6oafoi7a2qwp@jackie> References: <20210819085533.1174-1-ming.qian@nxp.com> <20210819085533.1174-2-ming.qian@nxp.com> <20220102164106.ptu4eet7rmwla7bg@jackie> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Ming, On Tue, 04. Jan 07:51, Ming Qian wrote: > > > -----Original Message----- > > From: Andriy Gelman [mailto:andriy.gelman@gmail.com] > > Sent: Monday, January 3, 2022 12:41 AM > > To: FFmpeg development discussions and patches > > Cc: Ming Qian > > Subject: [EXT] Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_context: > > resume the decoding process after source change event received. > > > > Caution: EXT Email > > > > On Thu, 19. Aug 16:55, Ming Qian wrote: > > > client need to resume the decoding process after it dequeues the > > > source change event. > > > no matter what's the return value of v4l2_resolution_changed(). > > > if the client doesn't resume the decoding process, the decoder may > > > keep waiting > > > > > > in documentation of v4l2 stateful decoder, we can see the following > > > description: > > > The client must continue the sequence as described below to > > > continue the decoding process. > > > 1. Dequeue the source change event. > > > Important > > > A source change triggers an implicit decoder drain, > > > similar to the explicit Drain sequence. The decoder is > > > stopped after it completes. The decoding process must be > > > resumed with either a pair of calls to > > > VIDIOC_STREAMOFF() and VIDIOC_STREAMON() on the > > CAPTURE > > > queue, or a call to VIDIOC_DECODER_CMD() with the > > > V4L2_DEC_CMD_START command. > > > 2. Continue with the Capture Setup sequence. > > > > Please also add that this fixes decoding of > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstreams > > .videolan.org%2Fffmpeg%2Fincoming%2F720p60.mp4&data=04%7C01% > > 7Cming.qian%40nxp.com%7Cea94a9c4cc0643b0a41f08d9ce0eadc5%7C686e > > a1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637767384703207931%7CU > > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6 > > Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=X4rKQX19MQg1gO3ILiBCQ > > qSLIvqovZLA95KKiyoVNzI%3D&reserved=0 on RPi4. > > > > Hi Andriy, > What's wrong with this stream? Everything is normal on my side when I play it using ffplay. > I couldn't decode the file on the Raspberry Pi4. After enqueuing the first few packets there was a dynamic resolution change event, and the start decode command was not sent. This is fixed by your patch. Thanks, -- Andriy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".