[FFmpeg-devel] [PATCH] doc/developer: patches should not cross libs or mix MAINTAINER changes in

[FFmpeg-devel] [PATCH] doc/developer: patches should not cross libs or mix MAINTAINER changes in

[Michael Niedermayer]

maintainer part inspired by IRC comments by lynne

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 doc/developer.texi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/developer.texi b/doc/developer.texi
index addee0d8263..eae3ade48a7 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -683,6 +683,10 @@ are notoriously left unchecked, which is a serious problem.
 @item
 Test your code with valgrind and or Address Sanitizer to ensure it's free
 of leaks, out of array accesses, etc.
+
+@item
+Changes to 2 libs which change both versions should be in 2 seperate patches.
+Non cosmetic changes to @file{MAINTAINERS} should not be in a patch with other changes.
 @end enumerate
 
 @chapter Patch review process
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: patches should not cross libs or mix MAINTAINER changes in

[Lynne]

4 Jan 2022, 21:06 by michael@niedermayer.cc:

> maintainer part inspired by IRC comments by lynne
>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  doc/developer.texi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/doc/developer.texi b/doc/developer.texi
> index addee0d8263..eae3ade48a7 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -683,6 +683,10 @@ are notoriously left unchecked, which is a serious problem.
>  @item
>  Test your code with valgrind and or Address Sanitizer to ensure it's free
>  of leaks, out of array accesses, etc.
> +
> +@item
> +Changes to 2 libs which change both versions should be in 2 seperate patches.
> +Non cosmetic changes to @file{MAINTAINERS} should not be in a patch with other changes.
>  @end enumerate 
>

LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: patches should not cross libs or mix MAINTAINER changes in

[Andreas Rheinhardt]

Michael Niedermayer:
> maintainer part inspired by IRC comments by lynne
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  doc/developer.texi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/developer.texi b/doc/developer.texi
> index addee0d8263..eae3ade48a7 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -683,6 +683,10 @@ are notoriously left unchecked, which is a serious problem.
>  @item
>  Test your code with valgrind and or Address Sanitizer to ensure it's free
>  of leaks, out of array accesses, etc.
> +
> +@item
> +Changes to 2 libs which change both versions should be in 2 seperate patches.
                ^                                                 ^
                maybe spell this out                              a

(I presume that the pre- and post-release version bump patches are
supposed to be exempt from this?)

> +Non cosmetic changes to @file{MAINTAINERS} should not be in a patch with other changes.
>  @end enumerate
>  
>  @chapter Patch review process
> 

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".