[FFmpeg-devel] Build break: VideoToolbox VP9 support breaks H.264-only build

[FFmpeg-devel] Build break: VideoToolbox VP9 support breaks H.264-only build

[Cameron Gutman]

I am building minimal ffmpeg libraries for my application using the following
configure command:

./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox

libavcodec.dylib now fails to link after the following commit:

commit a41a2efc85f8c88caec10040ee437562f9d0b947
Author: rcombs <rcombs@rcombs.me>
Date:   Sat Nov 13 02:43:06 2021 -0600

    lavc/videotoolbox: add VP9 hardware acceleration
    
    On M1 Max, this supports profiles 0 and 2, but not 1 and 3.


The error is:

Undefined symbols for architecture x86_64:
  "_ff_videotoolbox_vpcc_extradata_create", referenced from:
      _videotoolbox_start in videotoolbox.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [libavcodec/libavcodec.59.dylib] Error 1


Perhaps ff_videotoolbox_vpcc_extradata_create() needs to go in videotoolbox.c
like the other ff_videotoolbox_*_extradata_create() functions?



Regards,
Cam
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Build break: VideoToolbox VP9 support breaks H.264-only build

[lance.lmwang]

On Mon, Jan 03, 2022 at 01:18:34PM -0600, Cameron Gutman wrote:
> I am building minimal ffmpeg libraries for my application using the following
> configure command:
> 
> ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox
> 
> libavcodec.dylib now fails to link after the following commit:
> 
> commit a41a2efc85f8c88caec10040ee437562f9d0b947
> Author: rcombs <rcombs@rcombs.me>
> Date:   Sat Nov 13 02:43:06 2021 -0600
> 
>     lavc/videotoolbox: add VP9 hardware acceleration
>     
>     On M1 Max, this supports profiles 0 and 2, but not 1 and 3.
> 
> 
> The error is:
> 
> Undefined symbols for architecture x86_64:
>   "_ff_videotoolbox_vpcc_extradata_create", referenced from:
>       _videotoolbox_start in videotoolbox.o
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> make: *** [libavcodec/libavcodec.59.dylib] Error 1
> 
> 
> Perhaps ff_videotoolbox_vpcc_extradata_create() needs to go in videotoolbox.c
> like the other ff_videotoolbox_*_extradata_create() functions?

I submit one patch for the error. If we move the function to videotoolbox.c, it's necessary to 
include vp9shared.h which will caused redefinitions of IntraPredMode with hevcdec.h.

> 
> 
> 
> Regards,
> Cam
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".