Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: lance.lmwang@gmail.com
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] Build break: VideoToolbox VP9 support breaks H.264-only build
Date: Tue, 4 Jan 2022 17:49:00 +0800
Message-ID: <20220104094900.GA4411@gmail.com> (raw)
In-Reply-To: <f494f5de-789e-a8a8-45e2-3338b945e6dc@gmail.com>

On Mon, Jan 03, 2022 at 01:18:34PM -0600, Cameron Gutman wrote:
> I am building minimal ffmpeg libraries for my application using the following
> configure command:
> 
> ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox
> 
> libavcodec.dylib now fails to link after the following commit:
> 
> commit a41a2efc85f8c88caec10040ee437562f9d0b947
> Author: rcombs <rcombs@rcombs.me>
> Date:   Sat Nov 13 02:43:06 2021 -0600
> 
>     lavc/videotoolbox: add VP9 hardware acceleration
>     
>     On M1 Max, this supports profiles 0 and 2, but not 1 and 3.
> 
> 
> The error is:
> 
> Undefined symbols for architecture x86_64:
>   "_ff_videotoolbox_vpcc_extradata_create", referenced from:
>       _videotoolbox_start in videotoolbox.o
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> make: *** [libavcodec/libavcodec.59.dylib] Error 1
> 
> 
> Perhaps ff_videotoolbox_vpcc_extradata_create() needs to go in videotoolbox.c
> like the other ff_videotoolbox_*_extradata_create() functions?

I submit one patch for the error. If we move the function to videotoolbox.c, it's necessary to 
include vp9shared.h which will caused redefinitions of IntraPredMode with hevcdec.h.

> 
> 
> 
> Regards,
> Cam
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-01-04  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 19:18 Cameron Gutman
2022-01-04  9:49 ` lance.lmwang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220104094900.GA4411@gmail.com \
    --to=lance.lmwang@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git