From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] 5.0 release
Date: Mon, 3 Jan 2022 21:36:21 +0100
Message-ID: <20220103203621.GU2829255@pb2> (raw)
In-Reply-To: <CAPYw7P64FBQp_7dWNQUAM_WEqm8Xk6diobiHXM0WEcfyaeRwUg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 4209 bytes --]
On Mon, Jan 03, 2022 at 09:29:40PM +0100, Paul B Mahol wrote:
> On Mon, Jan 3, 2022 at 9:14 PM Michael Niedermayer <michael@niedermayer.cc>
> wrote:
>
> > On Mon, Jan 03, 2022 at 08:25:44PM +0100, Paul B Mahol wrote:
> > > On Mon, Jan 3, 2022 at 7:58 PM Michael Niedermayer <
> > michael@niedermayer.cc>
> > > wrote:
> > >
> > > > On Mon, Jan 03, 2022 at 07:04:48PM +0100, Paul B Mahol wrote:
> > > > > On Mon, Jan 3, 2022 at 6:18 PM Hendrik Leppkes <h.leppkes@gmail.com>
> > > > wrote:
> > > > >
> > > > > > On Mon, Jan 3, 2022 at 5:14 PM Michael Niedermayer
> > > > > > <michael@niedermayer.cc> wrote:
> > > > > > >
> > > > > > > On Mon, Jan 03, 2022 at 06:31:37AM +0100, Jean-Baptiste Kempf
> > wrote:
> > > > > > > > On Fri, 31 Dec 2021, at 20:40, Michael Niedermayer wrote:
> > > > > > > > >> It would be nice to have a public date set a few days into
> > the
> > > > > > future.
> > > > > > > > >
> > > > > > > > > yes, i intended to do that, unless people wanted a ASAP/NOW
> > > > branch
> > > > > > > >
> > > > > > > > So what are the open topics, besides the Audio Channel Layout
> > API?
> > > > > > >
> > > > > > > the mov issue was fixed, channels dont seem to happen
> > > > > > > theres a regression with 946493eb3e072b499909f606625480c928834a44
> > > > > > > that ive reported 1 day after the patch was posted and pinged 11
> > days
> > > > > > later
> > > > > > >
> > > > > > > 221073 rsF 1112 16:11 To ffmpeg-devel (2,3K) Re: [FFmpeg-devel]
> > > > > > [FFmpeg-cvslog] avcodec/mlpdec: cover case when >2 channels are in
> > > > single
> > > > > > substream
> > > > > > > 221074 sF 1123 0:00 To ffmpeg-devel (3,5K) └─>
> > > > > > >
> > > > > > > thats not branch blocking, a bugfix is just a normal backport
> > > > > > > I dont have the file that
> > 946493eb3e072b499909f606625480c928834a44
> > > > fixes
> > > > > > > so trying to fix it is like working blindfolded, thats why ive
> > so far
> > > > > > > waited for the author to respond and take a look
> > > > > > >
> > > > > >
> > > > > > As far as I can tell, the recent mlpdec changes seem to be
> > intended to
> > > > > > fix playback of streams made by our own experimental encoder, and
> > not
> > > > > > independent samples.
> > > >
> > > > How can that be reproduced ?
> > > > I tried with a 5.1 stream and the decoded output is not changing with
> > this
> > > > patch
> > > >
> > > >
> > > > > > So perhaps those should be reverted for a stable release (or
> > > > > > generally), seeing as there is no response 2 months later, and no
> > > > > > indication what they actually fix.
> > > > > >
> > > > > > The available whitepapers and bitstream syntax document on
> > TrueHD/MLP
> > > > > > also do not seem to support more then 2 channel in the first
> > > > > > substream, limiting it to a stereo presentation in the first, up
> > to 6
> > > > > > channel in the second, and up to 8 channel in the third substream
> > (and
> > > > > > 16 in the extended substream)
> > > > > >
> > > > >
> > > > > This statement is not in sync with reality.
> > > > >
> > > > > I have sample that 946... fixes, single stream with > 2 channels.
> > > >
> > > > Iam not sure i understand what you mean exactly but
> > > >
> > > > the sample which it breaks is here:
> > > > https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket1726/Mono.thd
> > > >
> > > > can you look into this issue, you as author of the change maybe
> > > > remember why you did it and so are better qualified to adjust it.
> > > >
> > >
> > > Sorry but that sample was never decoded properly. As it is not mono and
> > it
> > > is not stereo.
> >
> > around the time of 3.2 it was decoded as mono and it sounds reasonable
> > after that until 946... it was decoded as stereo with only the left channel
> > after 946... it now doesnt decode at all
> >
> > it would be nice if we could support this kind of file
> >
>
> To really support it, it needs both streams to be presented.
yes
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No great genius has ever existed without some touch of madness. -- Aristotle
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-03 20:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211125171932.GC2829255@pb2>
[not found] ` <20211213152557.GL2829255@pb2>
[not found] ` <CABcAi1jFnkGd-dyLy_iOHhKEVUz=OPYXp23X326_6okM+zW8Aw@mail.gmail.com>
[not found] ` <20211214161924.GM2829255@pb2>
[not found] ` <CABcAi1h45bkw4rmYJYEJrEaqOybbFvqXZFAAJ6F5=Mo4+BPHVg@mail.gmail.com>
2021-12-15 14:52 ` Michael Niedermayer
2021-12-15 15:08 ` Diederick C. Niehorster
2021-12-15 15:15 ` Michael Niedermayer
[not found] ` <3238136b-1f43-49ae-b2d6-ce98b98e24f0@www.fastmail.com>
2021-12-22 14:03 ` Michael Niedermayer
2021-12-22 14:05 ` James Almer
2021-12-22 16:44 ` Jean-Baptiste Kempf
2021-12-27 23:55 ` Michael Niedermayer
2021-12-31 16:52 ` Michael Niedermayer
2021-12-31 17:15 ` Gyan Doshi
2021-12-31 19:40 ` Michael Niedermayer
2022-01-02 14:12 ` Anton Khirnov
2022-01-02 14:29 ` James Almer
2022-01-02 14:50 ` Zane van Iperen
2022-01-02 15:09 ` James Almer
2022-01-02 15:52 ` Zane van Iperen
2022-01-02 16:28 ` Lynne
2022-01-02 17:11 ` Michael Niedermayer
2022-01-02 18:12 ` Lynne
2022-01-02 22:29 ` Michael Niedermayer
2022-01-02 22:32 ` Michael Niedermayer
2022-01-03 5:31 ` Jean-Baptiste Kempf
2022-01-03 16:14 ` Michael Niedermayer
2022-01-03 17:17 ` Hendrik Leppkes
2022-01-03 17:19 ` Hendrik Leppkes
2022-01-03 18:04 ` Paul B Mahol
2022-01-03 18:58 ` Michael Niedermayer
2022-01-03 19:25 ` Paul B Mahol
2022-01-03 20:14 ` Michael Niedermayer
2022-01-03 20:29 ` Paul B Mahol
2022-01-03 20:36 ` Michael Niedermayer [this message]
2022-01-03 19:23 ` Michael Niedermayer
2022-01-04 2:11 ` Soft Works
2021-12-31 19:08 ` Lynne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103203621.GU2829255@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git