From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 063AC410BB
	for <ffmpegdev@gitmailbox.com>; Mon,  3 Jan 2022 08:40:17 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 69E3368B175;
	Mon,  3 Jan 2022 10:40:16 +0200 (EET)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E62AF68B17F
 for <ffmpeg-devel@ffmpeg.org>; Mon,  3 Jan 2022 10:40:09 +0200 (EET)
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id 95EBB4949D;
 Mon,  3 Jan 2022 09:40:09 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1641199209; bh=WDL0Gl1HaoIq2KzGEAkdbxiWXa8J21QvbNnJ7Dbe2Fw=;
 h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
 b=GNU55nY+o8c055qBvgIbzjvKHvic+35q6H9vfThrxAdVAeSjPc57kRv7Lv8/at1+y
 kpVN4aN78dI3Jg098R1j7Pw/gv0xYy3Gz1JNWW1K8STaBYsWE1HXe2rNlg0LZ8Sgq1
 hBUarhoYXmcsrFBy2mtx0Hij4l23Gifm4Zlp1Exs=
Date: Mon, 3 Jan 2022 09:40:09 +0100
Message-ID: <20220103094009.GB67947@xor.haasn.dev>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <20220103002727.38840-1-ffmpeg@haasn.xyz>
References: <20220103002727.38840-1-ffmpeg@haasn.xyz>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH v10 1/6] lavu/frame: Add Dolby Vision
 metadata side data type
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Niklas Haas <git@haasn.dev>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20220103094009.GB67947@xor.haasn.dev/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 03 Jan 2022 01:27:22 +0100 Niklas Haas <ffmpeg@haasn.xyz> wrote:
> +/**
> + * Dolby Vision RPU data mapping parameters.
> + *
> + * @note sizeof(AVDOVIDataMapping) is not part of the public ABI.
> + */
> +typedef struct AVDOVIDataMapping {
> +    uint8_t vdr_rpu_id;
> +    uint8_t mapping_color_space;
> +    uint8_t mapping_chroma_format_idc;
> +    AVDOVIReshapingCurve curves[3]; /* per component */
> +
> +    /* Non-linear inverse quantization */
> +    enum AVDOVINLQMethod nlq_method_idc;
> +    uint32_t num_x_partitions;
> +    uint32_t num_y_partitions;
> +    AVDOVINLQParams nlq[3]; /* per component */
> +} AVDOVIDataMapping;

It just occurred to me that we also cannot make AVDOVIReshapingCurve or
AVDOVINLQParams extensible if we're going to store them in an array.

So I think that locks us into making these structs fixed size, avoiding
the issue altogether, but probably making future extensions to this API
somewhat uglier.

Thoughts?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".