From: "zozobreak@163.com" <zozobreak@163.com>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v6] avcodec/h264_slice: add warning log when droping picture at 'h264_select_output_frame'
Date: Thu, 30 Dec 2021 17:19:09 +0800
Message-ID: <2021123017190852739810@163.com> (raw)
In-Reply-To: <20211230090003.GA5672@gmail.com>
This will lost the droped picture's infomation, lead to hard to debug when this error happens.
zozobreak@163.com
From: lance.lmwang
Date: 2021-12-30 17:00
To: ffmpeg-devel
Subject: Re: [FFmpeg-devel] [PATCH v6] avcodec/h264_slice: add warning log when droping picture at 'h264_select_output_frame'
On Thu, Dec 30, 2021 at 03:24:28PM +0800, zourenyi wrote:
> since there is only debug log 'no picture ooo' when droping a picture,
> I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps',
> FFmpeg keeped silence about this error, so a warning log is much helpfull about this.
>
> Signed-off-by: zourenyi <zozobreak@163.com>
> ---
> libavcodec/h264_slice.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
> index c21004df97..f347d8ee1a 100644
> --- a/libavcodec/h264_slice.c
> +++ b/libavcodec/h264_slice.c
> @@ -1533,7 +1533,13 @@ static int h264_select_output_frame(H264Context *h)
> }
> }
> } else {
> - av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : "");
> + if (out_of_order) {
> + av_log(h->avctx, AV_LOG_WARNING,
> + "drop picture(%c, %d/%" PRId64 ") because out of order\n",
> + av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts);
> + } else {
> + av_log(h->avctx, AV_LOG_DEBUG, "no picture\n");
> + }
> }
I prefer to not change the old message, just use warning level for ooo, like below:
int loglevel = out_of_order ? AV_LOG_WARNING : AV_LOG_DEBUG;
av_log(h->avctx, loglevel, "no picture %s\n", out_of_order ? "ooo" : "");
>
> return 0;
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2021-12-30 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 7:24 zourenyi
2021-12-30 7:35 ` Steven Liu
2021-12-30 9:00 ` lance.lmwang
2021-12-30 9:19 ` zozobreak [this message]
2021-12-30 10:45 ` lance.lmwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2021123017190852739810@163.com \
--to=zozobreak@163.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git