From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6899040CC9 for ; Thu, 30 Dec 2021 09:00:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 39DBF68AD92; Thu, 30 Dec 2021 11:00:16 +0200 (EET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4A9FC68AC7B for ; Thu, 30 Dec 2021 11:00:09 +0200 (EET) Received: by mail-pl1-f174.google.com with SMTP id p14so17827730plf.3 for ; Thu, 30 Dec 2021 01:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=IAeW0AxZfyLEDqIm2fmWRYFRKnBOaZowe2q/hmqqk/U=; b=inGkhST8++3krTmHNTac214/fO3deu+/JC6CSpaVUqATPo0bMxh2QX/yOZF/kDtNQ7 orq7YF4Ws9H9NNWhJDJxNQ9ZvBo69Upyg4U73mcmZqEyFDqcFJFeSm3dh6qB4os+pYO9 C0qMuuLE/N6iX9c4WGplpN945ONklxvc/C7n8/w1rHDyLr+amx/ctdp4orPWus7vvzCC bBc/HT1hj9zSGewTIGhlTBCFM5KK5aHP8HdZzZm7NR80EHaKuwfkT0RgpXtp6Vhir0NJ 7TaWleH2b0RGCrcVpBC2M5qT5WHve1N1Fpt5wpCAkuPYeJTpOteQbh8tBfXw+K0KaMN9 Glig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=IAeW0AxZfyLEDqIm2fmWRYFRKnBOaZowe2q/hmqqk/U=; b=jrFwVjijZ7hQ6iDb3O25g6cNy0XWRVd4CSoVjhuQmNKfsZmlPRJqN6bruPHlVWZoKR tyrRKtcHrjihSCeViFecJ1JSTzLLSfLV7vU61CsXSy0EtJ8PVqiHOoQEKRAJMq8EKFtk NdS3G2f6TUxIHHWPOSqcV2rZSw55nU1J//H0HKa4rJeh3LHK1ntwc1nVSSAI/kKkM8O6 qsQyFGvmERr89jkuxFk8yS0GR7Lt+zEPX5+Ndw7rnPBxzDEgIxTXuLJQcdx/X4mzklm2 x6PiCTsRF2qhrEnNsB3GjTkeE8YLiX8XiA7WA1PBXMWmvSt7Sn27n9eWC/Q3sAiKfd8M 8/Yg== X-Gm-Message-State: AOAM532pglMSOp9B6eCwaxJPy41l69CLXuPT8NmkFh6zQAGWf8Y4YyNn eKXNWQKhNIieSSoYNHG/Up64G7IQOhY= X-Google-Smtp-Source: ABdhPJyV5Z9yjOrBMH8GSrP+h9zoflEc08dFeT3E/jvTwXU8BEjeLml73LU5fKuB2wW6ObxVVTwyOg== X-Received: by 2002:a17:902:700c:b0:149:5536:1ac4 with SMTP id y12-20020a170902700c00b0014955361ac4mr29115157plk.11.1640854807123; Thu, 30 Dec 2021 01:00:07 -0800 (PST) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id j7sm26824483pfu.164.2021.12.30.01.00.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Dec 2021 01:00:06 -0800 (PST) Date: Thu, 30 Dec 2021 17:00:03 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20211230090003.GA5672@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <20211230072428.21067-1-zozobreak@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211230072428.21067-1-zozobreak@163.com> Subject: Re: [FFmpeg-devel] [PATCH v6] avcodec/h264_slice: add warning log when droping picture at 'h264_select_output_frame' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Dec 30, 2021 at 03:24:28PM +0800, zourenyi wrote: > since there is only debug log 'no picture ooo' when droping a picture, > I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps', > FFmpeg keeped silence about this error, so a warning log is much helpfull about this. > > Signed-off-by: zourenyi > --- > libavcodec/h264_slice.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > index c21004df97..f347d8ee1a 100644 > --- a/libavcodec/h264_slice.c > +++ b/libavcodec/h264_slice.c > @@ -1533,7 +1533,13 @@ static int h264_select_output_frame(H264Context *h) > } > } > } else { > - av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : ""); > + if (out_of_order) { > + av_log(h->avctx, AV_LOG_WARNING, > + "drop picture(%c, %d/%" PRId64 ") because out of order\n", > + av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts); > + } else { > + av_log(h->avctx, AV_LOG_DEBUG, "no picture\n"); > + } > } I prefer to not change the old message, just use warning level for ooo, like below: int loglevel = out_of_order ? AV_LOG_WARNING : AV_LOG_DEBUG; av_log(h->avctx, loglevel, "no picture %s\n", out_of_order ? "ooo" : ""); > > return 0; > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".