From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 91A2440CB3 for ; Thu, 30 Dec 2021 06:12:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 935D568A306; Thu, 30 Dec 2021 08:11:59 +0200 (EET) Received: from mail-m974.mail.163.com (mail-m974.mail.163.com [123.126.97.4]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F27568A306 for ; Thu, 30 Dec 2021 08:11:51 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=kiqWL FsV5TY0s7XiZEKULrcSgdbeEoJiTZIVcnEdEfA=; b=MfZPtY+g/ZaVmQvz4PhpC CqvcZIHi8vhyO+tX4Td2gYmUi9odDtjt0i+3fU0E+N/pLMQ0mBSiwHOTb+zViTnM /+kXNMUW4tmA51865ABrH5GAqvp+9ULJGutDdd/djco5v7gVOGeCg9N4V2oHWUze pKSjNkA7b0hThVqrIeY47w= Received: from wuque-pc2.dev-wh.douyu.tv (unknown [220.249.79.114]) by smtp4 (Coremail) with SMTP id HNxpCgBXDSajTc1hpiGkDQ--.1041S2; Thu, 30 Dec 2021 14:11:48 +0800 (CST) From: zourenyi To: ffmpeg-devel@ffmpeg.org Date: Thu, 30 Dec 2021 14:11:45 +0800 Message-Id: <20211230061145.20864-1-zozobreak@163.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CM-TRANSID: HNxpCgBXDSajTc1hpiGkDQ--.1041S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XFWUAw1DWFy3CF45CryfWFg_yoWDtrb_Ca yxCr13GF4DGay2k3WfWr4YyF97uan8C3W3uas7tws0gFZxGr1UGFykXF98Cr15W3Z7GFW3 KF4Fvr1vkw4xKjkaLaAFLSUrUUUU1b8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRAvtZ3UUUUU== X-Originating-IP: [220.249.79.114] X-CM-SenderInfo: p2r20upuhdyqqrwthudrp/xtbBlwR5w1SIlrbIogAAs- Subject: [FFmpeg-devel] [PATCH v5] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: zourenyi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: since there is only debug log 'no picture ooo' when droping a picture, I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps', FFmpeg keeped silence about this error, so a warning log is much helpfull about this. Signed-off-by: zourenyi --- libavcodec/h264_slice.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index c21004df97..f347d8ee1a 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -1533,7 +1533,13 @@ static int h264_select_output_frame(H264Context *h) } } } else { - av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : ""); + if (out_of_order) { + av_log(h->avctx, AV_LOG_WARNING, + "drop picture(%c, %d/%" PRId64 ") because out of order\n", + av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts); + } else { + av_log(h->avctx, AV_LOG_DEBUG, "no picture\n"); + } } return 0; -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".