From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6A7BC40C6A for ; Wed, 29 Dec 2021 12:37:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8842068AED3; Wed, 29 Dec 2021 14:37:44 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D54268A84E for ; Wed, 29 Dec 2021 14:37:38 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id EFBDEFF802 for ; Wed, 29 Dec 2021 12:37:36 +0000 (UTC) Date: Wed, 29 Dec 2021 13:37:35 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20211229123735.GA2829255@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] libx264: Set min build version to 158 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4993270408025065903==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4993270408025065903== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sXQQlnzghDE6CB2D" Content-Disposition: inline --sXQQlnzghDE6CB2D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 29, 2021 at 05:16:25PM +1100, Matt Oliver wrote: > Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" >=20 > Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to > static builds (although is required for shared builds). This flag is set = by > x264 in its pkgconfig as required since build 158 > (a615f027ed172e2dd5380e736d487aa858a0c4ff) from July 2019. So this patch > updates configure to require a newer x264 build that correctly sets the > imports flag. >=20 > Alternatively we can detect the x264 build version in configure and keep > the fallback of manually setting the flag on older x264 builds that arent > using pkgconfig (to keep the old behaviour) but that requires some complex > configure changes. >=20 > Signed-off-by: Matt Oliver > --- > configure | 8 +++----- > libavcodec/libx264.c | 4 ---- > 2 files changed, 3 insertions(+), 9 deletions(-) I think this would effectivly drop ubuntu LTS support which seem to ship older versions thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If the United States is serious about tackling the national security threat= s=20 related to an insecure 5G network, it needs to rethink the extent to which = it values corporate profits and government espionage over security.-Bruce Schn= eier --sXQQlnzghDE6CB2D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYcxWjwAKCRBhHseHBAsP q+jPAJ9PGIise8hfB6gQDsZWl2c3TNDRXQCgjz8wDONW5FA6OnV2KnbfQ2eldG0= =hY+4 -----END PGP SIGNATURE----- --sXQQlnzghDE6CB2D-- --===============4993270408025065903== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4993270408025065903==--