From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] avformat/mov: correct 0 valued entries in stts
Date: Mon, 27 Dec 2021 11:27:10 +0530
Message-ID: <20211227055711.63060-1-ffmpeg@gyani.pro> (raw)
As per ISO 14496-12, sample duration of 0 is invalid except for
the last entry.
In addition, also catch 0 value for sample count.
---
libavformat/mov.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 2aed6e80ef..fb7406cdd6 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -2968,6 +2968,18 @@ static int mov_read_stts(MOVContext *c, AVIOContext *pb, MOVAtom atom)
av_log(c->fc, AV_LOG_TRACE, "sample_count=%d, sample_duration=%d\n",
sample_count, sample_duration);
+ if (!sample_count) {
+ av_log(c->fc, AV_LOG_WARNING, "invalid sample count of 0 in stts for st %d at entry %u; changing to 1.\n",
+ c->fc->nb_streams-1, i);
+ sc->stts_data[i].count = sample_count = 1;
+ }
+
+ if (!sample_duration && i != entries-1) {
+ av_log(c->fc, AV_LOG_WARNING, "invalid sample delta of 0 in stts for st %d at entry %u; changing to 1.\n",
+ c->fc->nb_streams-1, i);
+ sc->stts_data[i].duration = sample_duration = 1;
+ }
+
duration+=(int64_t)sample_duration*(uint64_t)sample_count;
total_sample_count+=sample_count;
}
--
2.33.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2021-12-27 5:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 5:57 Gyan Doshi [this message]
2021-12-27 6:38 ` "zhilizhao(赵志立)"
2021-12-27 6:43 ` "zhilizhao(赵志立)"
2021-12-27 19:08 ` Michael Niedermayer
2021-12-27 20:03 ` Gyan Doshi
2021-12-27 23:48 ` Michael Niedermayer
2021-12-28 16:56 ` Gyan Doshi
2021-12-29 12:28 ` Michael Niedermayer
2021-12-29 16:09 ` Gyan Doshi
2021-12-29 18:08 ` Michael Niedermayer
2021-12-30 4:37 ` Gyan Doshi
2021-12-30 14:16 ` Michael Niedermayer
2021-12-30 17:09 ` Gyan Doshi
2021-12-30 17:55 ` Michael Niedermayer
2021-12-30 18:12 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211227055711.63060-1-ffmpeg@gyani.pro \
--to=ffmpeg@gyani.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git