From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8A44640957 for ; Fri, 24 Dec 2021 09:55:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E73B568B29E; Fri, 24 Dec 2021 11:55:31 +0200 (EET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CB35768B265 for ; Fri, 24 Dec 2021 11:55:25 +0200 (EET) Received: by mail-pl1-f174.google.com with SMTP id n16so6347827plc.2 for ; Fri, 24 Dec 2021 01:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Kz+nIbBRdOi+gsAlt4zw/fb/+H0cPZirbAzl1PtmgBI=; b=V5o1tTEgYmpJ2YNnibtf2mI36NVr2fPkowvvMl7Wcue8TDFCHQ6O5xTreQHdM/CKSl gdbVwBEfzcIz7cSmO5UUZ3JfFKTB3eXSRZMHOYkp5eRKbepG6d/MS3f1MGSKoDoY1WEk GGqw43Y2gV7t9Nl5gYhyvh6FYwxCw97xON0TYlNtRRJWq/sNynmyGpcg9Oz3azfChiJt eAWs6Y5VqzTnbyIMJVwIKd0diHukXFfNcpT+Upy1Sjx8WwFTFqbKC+ElGDTY15UEk6lI FHq+zRFee4mhpljj3rgXHunspQffD0t4whhVlFYYNA99LZ8k0ASrZvjpTZD7qQJSe2p7 Jy9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=Kz+nIbBRdOi+gsAlt4zw/fb/+H0cPZirbAzl1PtmgBI=; b=qDo2xktK+bzX8EwNFX6nxoKpWyIoXu+IMqkXWcpZbXgqKR9tj0Gy60/tB5NfMGUxxV afMPZYw/lXNCL4GqUVTDOTQiy3eFl+4G/nxsZBevqXu265h//+RrIlTryG7PgIFcw16i 6tndAJKK73Mi0zY0HvX71hjJQyO/Ib9B045OYF3cI+1o2VFXlPSnwevBVzrFZF9Vl4zs s3p6ZrMAPmBnftjlRjfT2sojFvlk1tNiLm32MTTr3hBebKrOEioiW4D42e3ZDKytbgPM oNrLH7JOliGQVNITlY5CvNp65cH/OI8so1MRU8yvsK4ixfL72/wTVGlgKYEQIuE9iEyb rSOQ== X-Gm-Message-State: AOAM533UH2GAw1CqNmT8NPcYOWHg+2K8sEYa1aAkX6449Mym0yFpQMqj XVn/EnhwWpGMmVDFimHkofvEsREL+3s= X-Google-Smtp-Source: ABdhPJwPdZRHn3Pe+7VHrWEv49ICvAN0ByrgT/waUqSdt2a+eiS2P4/MZInX94gm8yec5FeukgNpXA== X-Received: by 2002:a17:90a:f405:: with SMTP id ch5mr7449560pjb.32.1640339723789; Fri, 24 Dec 2021 01:55:23 -0800 (PST) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id w76sm8148761pff.21.2021.12.24.01.55.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Dec 2021 01:55:23 -0800 (PST) Date: Fri, 24 Dec 2021 17:55:20 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20211224095520.GA6726@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <20210806021033.31954-1-haihao.xiang@intel.com> <6196106b1fba86f91e4587afb9cbfe3527f582a5.camel@intel.com> <20211224081715.GA29574@gmail.com> <8934708a136d272ca0df2d3160f11b121722a49a.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8934708a136d272ca0df2d3160f11b121722a49a.camel@intel.com> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Dec 24, 2021 at 08:47:38AM +0000, Xiang, Haihao wrote: > On Fri, 2021-12-24 at 16:17 +0800, lance.lmwang@gmail.com wrote: > > On Fri, Dec 24, 2021 at 07:35:25AM +0000, Xiang, Haihao wrote: > > > On Fri, 2021-08-06 at 10:10 +0800, Haihao Xiang wrote: > > > > The SDK may insert picture timing SEI for hevc and the code to set mfx > > > > parameter has been added in qsvenc, however the corresponding option is > > > > missing in the hevc option array > > > > --- > > > > libavcodec/qsvenc_hevc.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > > > > index b7b2f5633e..1e31968673 100644 > > > > --- a/libavcodec/qsvenc_hevc.c > > > > +++ b/libavcodec/qsvenc_hevc.c > > > > @@ -248,6 +248,7 @@ static const AVOption options[] = { > > > > { "tile_rows", "Number of rows for tiled > > > > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, > > > > 0, > > > > UINT16_MAX, VE }, > > > > { "recovery_point_sei", "Insert recovery point SEI > > > > messages", OFFSET(qsv.recovery_point_sei), AV_OPT_TYPE_INT, { > > > > .i64 > > > > = -1 }, -1, 1, VE }, > > > > { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), > > > > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE}, > > > > + { "pic_timing_sei", "Insert picture timing SEI with > > > > pic_struct_syntax > > > > element", OFFSET(qsv.pic_timing_sei), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, > > > > VE > > > > It's better to use AV_OPT_TYPE_BOOL if the option is used for on/off or > > enable/disable. > > > > Thanks for your comment. I'll change it to AV_OPT_TYPE_BOOL, > > > I think you need to add description in the doc for the new options if > > possible. > > Currently there isn't a doc for qsv decoder, we'll try to add it later. QSV encoder have one section in in doc/encoders.texi already although not all of options are included. $ grep "QSV encoders" doc/encoders.texi @section QSV encoders > > Thanks > Haihao > > > > > > > }, > > > > > > > > { NULL }, > > > > }; > > > > > > Will apply > > > > > > -Haihao > > > > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".