From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AD2184091F for ; Fri, 24 Dec 2021 08:17:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6C8468B26D; Fri, 24 Dec 2021 10:17:27 +0200 (EET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1C72968B21B for ; Fri, 24 Dec 2021 10:17:21 +0200 (EET) Received: by mail-pj1-f43.google.com with SMTP id lr15-20020a17090b4b8f00b001b19671cbebso7847996pjb.1 for ; Fri, 24 Dec 2021 00:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=gVN5tn5hO4MLKYYpZZTb8EZUiXll8hKhNvj26nZZUfM=; b=NljEQNdMQKxcJlKHr0FrIatVX9UxmQXzB7+KizQONj1xI6qb2yEDMzOngyas3n5spd SaD+hiCLCBxFT7vroOP31jkBwqV2ARXB/ll2yV3XhPt71F6EpFz/Rdq4jQL+7svkqnra SL1Rw4S0dzHOpdlmv4p9i5nsba4AYO+7kq0cLZ2xKUX49JXDVhP3wNB0HV+/4zDYbrn6 9QPgad8XZ2HTZswshYFclCt3s9AdRxWRVkvnB+sgyxs35RLlnZO7/aRxEcDSDHw1W9n2 CyLisq39wNU/kgXuG37PeuL8UwFwLAMt+uzj8fJLP9OhtNXQhANpNceAKFDYn9KoaNM4 5NZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=gVN5tn5hO4MLKYYpZZTb8EZUiXll8hKhNvj26nZZUfM=; b=QHOWXnNuOZIMl+HJLzMTck6VXlBDMHj3OKAXIQekwmBTOR8H4AiW6WVD3lo3NviOVD j1iDeKYEa7MhtvjlHwWH3J3fO4MOs/EIyM7Yef5+/FRXV3XHrLJ70Dqf6jDy/5AQncda TOx87FJtFs9MYPZNeR9+V6ttMoQySwY8N5UAXNyKZeucSfizobdDmp/ShFjVmn032+pH BwX/r+UmkiXyqpt4M4NCHE0VmLoyJZmFz+uyGQ16mEsuzZOo7N0msvQm/2WIYNnzIam9 VH5rY9j1I8iV+G5hDma2ic3zhjd4FT5d1vtKO/gZUrDuMtOkpFspUwD+aRqKmTrv1HFG CjaA== X-Gm-Message-State: AOAM531HUQirYFNkmLjuLBMcBJ8MtCOwSeRyPmeTMoBCAkF0IyFjSkwG xIcBc3yZLT9bBluhnvifzkxWbnE+pH0= X-Google-Smtp-Source: ABdhPJzXe1IP9Ou5d9z93XmaGv7ilxRvg5YFCpypq4Af6Rw07KwgtXxa4HwsbTiwULBITgH1xk+OLA== X-Received: by 2002:a17:90a:4987:: with SMTP id d7mr6669938pjh.22.1640333838547; Fri, 24 Dec 2021 00:17:18 -0800 (PST) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id w127sm8240330pfw.149.2021.12.24.00.17.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Dec 2021 00:17:18 -0800 (PST) Date: Fri, 24 Dec 2021 16:17:15 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20211224081715.GA29574@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <20210806021033.31954-1-haihao.xiang@intel.com> <6196106b1fba86f91e4587afb9cbfe3527f582a5.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6196106b1fba86f91e4587afb9cbfe3527f582a5.camel@intel.com> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Dec 24, 2021 at 07:35:25AM +0000, Xiang, Haihao wrote: > On Fri, 2021-08-06 at 10:10 +0800, Haihao Xiang wrote: > > The SDK may insert picture timing SEI for hevc and the code to set mfx > > parameter has been added in qsvenc, however the corresponding option is > > missing in the hevc option array > > --- > > libavcodec/qsvenc_hevc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > > index b7b2f5633e..1e31968673 100644 > > --- a/libavcodec/qsvenc_hevc.c > > +++ b/libavcodec/qsvenc_hevc.c > > @@ -248,6 +248,7 @@ static const AVOption options[] = { > > { "tile_rows", "Number of rows for tiled > > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, > > UINT16_MAX, VE }, > > { "recovery_point_sei", "Insert recovery point SEI > > messages", OFFSET(qsv.recovery_point_sei), AV_OPT_TYPE_INT, { .i64 > > = -1 }, -1, 1, VE }, > > { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), > > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE}, > > + { "pic_timing_sei", "Insert picture timing SEI with pic_struct_syntax > > element", OFFSET(qsv.pic_timing_sei), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, VE It's better to use AV_OPT_TYPE_BOOL if the option is used for on/off or enable/disable. I think you need to add description in the doc for the new options if possible. > > }, > > > > { NULL }, > > }; > > Will apply > > -Haihao > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".