Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 5/5] avformat/mvdec: Check bytes_per_sample
Date: Thu, 23 Dec 2021 22:15:27 +0100
Message-ID: <20211223211527.20408-5-michael@niedermayer.cc> (raw)
In-Reply-To: <20211223211527.20408-1-michael@niedermayer.cc>

Fixes: division by zero
Fixes: 42814/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-4787014237552640

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/mvdec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c
index 1a5012e5076..390f6ba4de8 100644
--- a/libavformat/mvdec.c
+++ b/libavformat/mvdec.c
@@ -366,6 +366,9 @@ static int mv_read_header(AVFormatContext *avctx)
             avpriv_request_sample(avctx, "Audio compression (format %i)", v);
         }
 
+        if (bytes_per_sample <= 0)
+            return AVERROR_INVALIDDATA;
+
         if (set_channels(avctx, ast, avio_rb32(pb)) < 0)
             return AVERROR_INVALIDDATA;
 
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2021-12-23 21:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23 21:15 [FFmpeg-devel] [PATCH 1/5] avcodec/targa: Check input size for uncompressed TGA before allocation Michael Niedermayer
2021-12-23 21:15 ` [FFmpeg-devel] [PATCH 2/5] avcodec/cdgraphics: avoid signed overflow in alpha Michael Niedermayer
2021-12-23 21:45   ` Andreas Rheinhardt
2021-12-25 10:43     ` Michael Niedermayer
2021-12-23 21:15 ` [FFmpeg-devel] [PATCH 3/5] avformat/flvdec: timestamps cannot use the full int64 range Michael Niedermayer
2021-12-30 20:44   ` Michael Niedermayer
2021-12-23 21:15 ` [FFmpeg-devel] [PATCH 4/5] avcodec/apedec: fix integer overflow in 8bit samples Michael Niedermayer
2021-12-30 20:42   ` Michael Niedermayer
2021-12-23 21:15 ` Michael Niedermayer [this message]
2021-12-23 23:07   ` [FFmpeg-devel] [PATCH 5/5] avformat/mvdec: Check bytes_per_sample Peter Ross
2021-12-24  3:32   ` John-Paul Stewart
2021-12-24 16:58     ` Michael Niedermayer
2021-12-24 20:29       ` John-Paul Stewart
2021-12-25 10:43         ` Michael Niedermayer
2021-12-30 21:11 ` [FFmpeg-devel] [PATCH 1/5] avcodec/targa: Check input size for uncompressed TGA before allocation Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211223211527.20408-5-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git