From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 3/5] avformat/flvdec: timestamps cannot use the full int64 range
Date: Thu, 23 Dec 2021 22:15:25 +0100
Message-ID: <20211223211527.20408-3-michael@niedermayer.cc> (raw)
In-Reply-To: <20211223211527.20408-1-michael@niedermayer.cc>
We do not support this as we multiply by 1000
Fixes: signed integer overflow: -45318575073853696 * 1000 cannot be represented in type 'long'
Fixes: 42804/clusterfuzz-testcase-minimized-ffmpeg_dem_LIVE_FLV_fuzzer-4630325425209344
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavformat/flvdec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index 44a7e5f93cc..b9e36b3ff1b 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -461,6 +461,8 @@ static int parse_keyframes_index(AVFormatContext *s, AVIOContext *ioc, int64_t m
d = av_int2double(avio_rb64(ioc));
if (isnan(d) || d < INT64_MIN || d > INT64_MAX)
goto invalid;
+ if (current_array == × && (d <= INT64_MIN / 1000 || d >= INT64_MAX / 1000))
+ goto invalid;
current_array[0][i] = d;
}
if (times && filepositions) {
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2021-12-23 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 21:15 [FFmpeg-devel] [PATCH 1/5] avcodec/targa: Check input size for uncompressed TGA before allocation Michael Niedermayer
2021-12-23 21:15 ` [FFmpeg-devel] [PATCH 2/5] avcodec/cdgraphics: avoid signed overflow in alpha Michael Niedermayer
2021-12-23 21:45 ` Andreas Rheinhardt
2021-12-25 10:43 ` Michael Niedermayer
2021-12-23 21:15 ` Michael Niedermayer [this message]
2021-12-30 20:44 ` [FFmpeg-devel] [PATCH 3/5] avformat/flvdec: timestamps cannot use the full int64 range Michael Niedermayer
2021-12-23 21:15 ` [FFmpeg-devel] [PATCH 4/5] avcodec/apedec: fix integer overflow in 8bit samples Michael Niedermayer
2021-12-30 20:42 ` Michael Niedermayer
2021-12-23 21:15 ` [FFmpeg-devel] [PATCH 5/5] avformat/mvdec: Check bytes_per_sample Michael Niedermayer
2021-12-23 23:07 ` Peter Ross
2021-12-24 3:32 ` John-Paul Stewart
2021-12-24 16:58 ` Michael Niedermayer
2021-12-24 20:29 ` John-Paul Stewart
2021-12-25 10:43 ` Michael Niedermayer
2021-12-30 21:11 ` [FFmpeg-devel] [PATCH 1/5] avcodec/targa: Check input size for uncompressed TGA before allocation Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223211527.20408-3-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git