From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9825640848 for ; Thu, 23 Dec 2021 13:56:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 03BD468B1AD; Thu, 23 Dec 2021 15:56:22 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 20F7C68B181 for ; Thu, 23 Dec 2021 15:56:16 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 1D5A924000C for ; Thu, 23 Dec 2021 13:56:14 +0000 (UTC) Date: Thu, 23 Dec 2021 14:56:14 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20211223135614.GL2829255@pb2> References: <20211217215155.19805-1-michael@niedermayer.cc> <20211217215155.19805-4-michael@niedermayer.cc> <163999391652.13029.15771139919327877252@lain.red.khirnov.net> <20211220105021.GQ2829255@pb2> <164001072509.13029.15596413999190684225@lain.red.khirnov.net> MIME-Version: 1.0 In-Reply-To: <164001072509.13029.15596413999190684225@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 4/4] avcodec/tiff: Use ff_set_dimensions() for setting up mjpeg context dimensions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0068111554152905500==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0068111554152905500== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lPa4LZgl2SyrhJbo" Content-Disposition: inline --lPa4LZgl2SyrhJbo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 20, 2021 at 03:32:05PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-12-20 11:50:21) > > On Mon, Dec 20, 2021 at 10:51:56AM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2021-12-17 22:51:55) > > > > Fixes: OOM > > >=20 > > > This is very non-obvious and could use more explanation. > >=20 > > I guess its obvious to me as ive seen this bug more than once > > the problem is that directly setting width/height leaves > > coded_w/h unset, then something sets coded_w/h and next time > > width/height is set again it is unrelated to the still set > > coded_w/h and theres a FFMAX() between coded_w and width > > so the image allocated is much bigger > > ff_set_dimension() breaks this chain by setting both width and > > coded_width=20 > >=20 > > should i add this long explanation above to the commit message > > or something shorter like > > "sets coded_width / coded_height too to keep them consistent with > > width / height" >=20 > Either is fine with me. ok will use the shorter and apply the 2 tiff patches thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --lPa4LZgl2SyrhJbo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYcR//gAKCRBhHseHBAsP q0azAJ4iu9zMLpmLPvEsO6PuhR880HQv2gCfQf6kTlS0XQzYTHwqAyZD/22yslo= =jVbv -----END PGP SIGNATURE----- --lPa4LZgl2SyrhJbo-- --===============0068111554152905500== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0068111554152905500==--