From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 05D254059B for ; Tue, 21 Dec 2021 13:55:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 427A768AFD1; Tue, 21 Dec 2021 15:54:34 +0200 (EET) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CD22168AA83 for ; Tue, 21 Dec 2021 15:54:27 +0200 (EET) Received: by mail-lf1-f41.google.com with SMTP id bt1so29424621lfb.13 for ; Tue, 21 Dec 2021 05:54:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PRQUajDDzo0yckQUc1NGOreX/fguC3LwegFuv42BzkQ=; b=h9qM8q+y1COkSGw8fkC5PXVQHHe+9VD3GWej7Puwsjzm3/W/qHX0QwjMNcbi7bemGC MghR9of0OXSvfX41M0jScqX+S8OM/KcLH7I2fIXzH1CBlofu+19RgkdWYmolCOGzQKXt ix1D3uccNtZuon5GZXW76vtfUw6Is5W9lGaMc4vR/ZFB2mPLUZc263URzRJ0iIEh7iXF F5SsayApG+uYRRejmm7O3iEhVY0K4no1rv4kDwD/KOxWlmoC6bRMJplWZFarQNFpbYqS KQvICJ0zcQ/6dPoTaNAg9cCu38/igklkLZWdYQfsMnxuCZwRF83v8HEGckrGrkkQiz5z zFyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PRQUajDDzo0yckQUc1NGOreX/fguC3LwegFuv42BzkQ=; b=3ZK+bqecpblEBlWT/zYh51s4+HKEhc9qq7wA1Cgq3+5P0ywEb8yzvLZHJhoDYe0cAU FkMZ/r7q7s7sTXcZoIll5mykifoFi1euwjqjyh1RI9xqIG97ci+56RR/6aJRh2f1ebaq ky/QPm83mJLH4E0OCbXMjFb4klEs75PDKgidyn4SMKlNXe1Q97Juv06Pge//Dmw1yqV6 Wu1eHhCtYftrfSQN4Z5DD1GC9dYlJVTap9Zo97vbtEmcJobEC4GXKZHG4jjo6jYRvmoH su8S/G0Rc1fn4x4Nlk3SO0ltMW503hrRmP5ojD6i60i9kzDEse5fHgHLLjk3FF0vJpg5 r+iA== X-Gm-Message-State: AOAM532StEo8ITUqHFBLEnySshjpt2IIXa5e4JqEbrqTVakG7Qm90ODg Lwxwxs85+2jB2YFjlEEhFmNQxgZ4J+MOcw== X-Google-Smtp-Source: ABdhPJzUgLi5ygu5j24bRM9Eyl4V7cAItDa23re82+BRoMc6xGRqjFVcJCOd6BPjMYUqxZhFqMNVaA== X-Received: by 2002:ac2:5547:: with SMTP id l7mr3103873lfk.324.1640094866752; Tue, 21 Dec 2021 05:54:26 -0800 (PST) Received: from localhost.localdomain ([196.244.192.13]) by smtp.gmail.com with ESMTPSA id k3sm2741285ljn.55.2021.12.21.05.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 05:54:26 -0800 (PST) From: Diederick Niehorster To: ffmpeg-devel@ffmpeg.org Date: Tue, 21 Dec 2021 14:53:30 +0100 Message-Id: <20211221135337.1348-6-dcnieho@gmail.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20211221135337.1348-1-dcnieho@gmail.com> References: <20211221135337.1348-1-dcnieho@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v7 05/12] avdevice/dshow: set no-seek flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Diederick Niehorster Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with, e.g., avformat_seek_file()) correctly yields -1 (operation not permitted) instead of -22 (invalid argument). This actually seems to apply to many other devices, at least the gdigrab, v4l2, vfwcap, x11grab, fbdev, kmsgrab and android_camera devices, from reading the source. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 5e6eb9c85d..0ef3b3d13e 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -1329,6 +1329,6 @@ const AVInputFormat ff_dshow_demuxer = { .read_header = dshow_read_header, .read_packet = dshow_read_packet, .read_close = dshow_read_close, - .flags = AVFMT_NOFILE, + .flags = AVFMT_NOFILE | AVFMT_NOBINSEARCH | AVFMT_NOGENSEARCH | AVFMT_NO_BYTE_SEEK, .priv_class = &dshow_class, }; -- 2.28.0.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".