From: Diederick Niehorster <dcnieho@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: Diederick Niehorster <dcnieho@gmail.com> Subject: [FFmpeg-devel] [PATCH v6 05/12] avdevice/dshow: set no-seek flags Date: Tue, 21 Dec 2021 13:12:32 +0100 Message-ID: <20211221121239.1201-6-dcnieho@gmail.com> (raw) In-Reply-To: <20211221121239.1201-1-dcnieho@gmail.com> avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with, e.g., avformat_seek_file()) correctly yields -1 (operation not permitted) instead of -22 (invalid argument). This actually seems to apply to many other devices, at least the gdigrab, v4l2, vfwcap, x11grab, fbdev, kmsgrab and android_camera devices, from reading the source. Signed-off-by: Diederick Niehorster <dcnieho@gmail.com> --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 5e6eb9c85d..0ef3b3d13e 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -1329,6 +1329,6 @@ const AVInputFormat ff_dshow_demuxer = { .read_header = dshow_read_header, .read_packet = dshow_read_packet, .read_close = dshow_read_close, - .flags = AVFMT_NOFILE, + .flags = AVFMT_NOFILE | AVFMT_NOBINSEARCH | AVFMT_NOGENSEARCH | AVFMT_NO_BYTE_SEEK, .priv_class = &dshow_class, }; -- 2.28.0.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2021-12-21 12:13 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-21 12:12 [FFmpeg-devel] [PATCH v6 00/12] dshow enhancements Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 01/12] avdevice/dshow: prevent NULL access Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 02/12] avdevice/dshow: implement option to use device video timestamps Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 03/12] avdevice/dshow: query graph and sample time only once Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 04/12] avdevice/dshow: handle unknown sample time Diederick Niehorster 2021-12-21 12:12 ` Diederick Niehorster [this message] 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 06/12] avdevice/dshow: implement get_device_list Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 07/12] avdevice/dshow: list_devices: show media type(s) per device Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 08/12] avdevice: add info about media types(s) to AVDeviceInfo Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 09/12] avdevice/dshow: add media type info to get_device_list Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 10/12] fftools: provide media type info for devices Diederick Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 11/12] avdevice/dshow: discover source color range/space/etc Diederick Niehorster 2021-12-21 12:35 ` Hendrik Leppkes 2021-12-21 13:11 ` Diederick C. Niehorster 2021-12-21 13:35 ` Hendrik Leppkes 2021-12-21 13:44 ` Diederick C. Niehorster 2021-12-21 12:12 ` [FFmpeg-devel] [PATCH v6 12/12] avdevice/dshow: select format with extended color info Diederick Niehorster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211221121239.1201-6-dcnieho@gmail.com \ --to=dcnieho@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git